Skip to content

[WIP] MULTIARCH-6017: make install-analysis-multi-p-p a blocking job - #82861

Open
Neha-dot-Yadav wants to merge 1 commit into
openshift:mainfrom
Neha-dot-Yadav:multi-power-install-analysis-blocking
Open

[WIP] MULTIARCH-6017: make install-analysis-multi-p-p a blocking job#82861
Neha-dot-Yadav wants to merge 1 commit into
openshift:mainfrom
Neha-dot-Yadav:multi-power-install-analysis-blocking

Conversation

@Neha-dot-Yadav

@Neha-dot-Yadav Neha-dot-Yadav commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Removes "optional": true from install-analysis-multi-p-p in release-ocp-5.0-multi.json, promoting the Power install analysis job from informing to a payload release blocker on the 5.0 multi nightly stream.

Prow job: periodic-ci-openshift-multiarch-main-nightly-5.0-install-analysis-all-multi-p-p

Summary by CodeRabbit

The Power install analysis job in the OpenShift 5.0 multi nightly stream is now a payload release blocker. The change removes "optional": true from install-analysis-multi-p-p while preserving its existing analysis and Prow configuration.

@openshift-ci-robot

openshift-ci-robot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@Neha-dot-Yadav: This pull request references MULTIARCH-6017 which is a valid jira issue.

Details

In response to this:

Removes "optional": true from install-analysis-multi-p-p in release-ocp-5.0-multi.json, promoting the Power install analysis job from informing to a payload release blocker on the 5.0 multi nightly stream.

Prow job: periodic-ci-openshift-multiarch-main-nightly-5.0-install-analysis-all-multi-p-p

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 4, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 4, 2026
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 4, 2026
@openshift-ci
openshift-ci Bot requested review from joepvd and smg247 August 4, 2026 07:29
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 872477c4-fbe2-4e22-a886-326a20de0e09

📥 Commits

Reviewing files that changed from the base of the PR and between 82029b8 and aa08bc8.

📒 Files selected for processing (2)
  • core-services/release-controller/_releases/priv/release-ocp-5.0-multi.json
  • core-services/release-controller/_releases/release-ocp-5.0-multi.json

Walkthrough

The install-analysis-multi-p-p verification job is now required in both release configurations. The public configuration also sets maxRetries: 2. Existing multi-job analysis and Prow job settings remain unchanged.

Changes

Release Verification Configuration

Layer / File(s) Summary
Update verification job requirements and retries
core-services/release-controller/_releases/release-ocp-5.0-multi.json, core-services/release-controller/_releases/priv/release-ocp-5.0-multi.json
The install-analysis-multi-p-p job is no longer optional. The public configuration allows two retries. Other job settings remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: joepvd, smg247

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the Jira issue and the main change: making install-analysis-multi-p-p a blocking job.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The commit changes only two JSON release configurations; the patch contains no Ginkgo test declarations or dynamic test titles.
Test Structure And Quality ✅ Passed The PR changes only two release-controller JSON files; no Ginkgo test code or It blocks are modified, so these test-quality requirements do not apply.
Microshift Test Compatibility ✅ Passed The commit changes only two release-controller JSON files and adds no Ginkgo e2e tests, so MicroShift API compatibility rules do not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull request changes only two release-controller JSON declarations and adds no Ginkgo e2e tests, so SNO test compatibility is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The PR changes release verification JSON only; the target job has retry, analysis, and Prow settings, with no scheduling constraints or manifests.
Ote Binary Stdout Contract ✅ Passed The commit changes only release-controller JSON configuration; no OTE binary or process-level stdout code is changed or implicated.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR changes only two release-controller JSON files. It adds no Ginkgo tests and introduces no IPv4 or external-connectivity assumptions.
No-Weak-Crypto ✅ Passed The commit changes only release JSON job settings; added lines contain no MD5, SHA1, DES, RC4, Blowfish, ECB, crypto implementation, or secret comparison.
Container-Privileges ✅ Passed The PR changes only release-controller JSON. No added privilege fields exist, and the referenced Prow job block has no privileged, host namespace, SYS_ADMIN, or escalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The diff changes only JSON release settings. It adds maxRetries and removes optional; no logging constructs or sensitive-data indicators are present.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@prb112

prb112 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2026

@prb112 prb112 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2026
@prb112

prb112 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

just need to fix the config

@Neha-dot-Yadav
Neha-dot-Yadav force-pushed the multi-power-install-analysis-blocking branch from 68da51f to 733fc19 Compare August 5, 2026 10:14
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2026

@prb112 prb112 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2026
Signed-off-by: Neha Yadav <neha.yadav3@ibm.com>
@Neha-dot-Yadav
Neha-dot-Yadav force-pushed the multi-power-install-analysis-blocking branch from 733fc19 to aa08bc8 Compare August 6, 2026 12:19
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2026
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@Neha-dot-Yadav: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

@Neha-dot-Yadav: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@prb112

prb112 commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@prb112: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@prb112

prb112 commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@prb112

prb112 commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

/unhold

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 6, 2026

@prb112 prb112 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Neha-dot-Yadav, prb112
Once this PR has been reviewed and has the lgtm label, please assign dgoodwin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants