Skip to content

telcov10: Minor fixes CNF compute LLC tests - #82886

Open
mrniranjan wants to merge 8 commits into
openshift:mainfrom
mrniranjan:amd_cnf_tests
Open

telcov10: Minor fixes CNF compute LLC tests#82886
mrniranjan wants to merge 8 commits into
openshift:mainfrom
mrniranjan:amd_cnf_tests

Conversation

@mrniranjan

@mrniranjan mrniranjan commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

1: Move cnf-compute-llc 4.22 from nightly to stable channel

  • Releases: candidate/nightly stream → stable channel (removed initial block)
  • Base images: Fixed stale 4.21 references → 4.22
  • Test name: ...-llc-nightly → ...-llc-stable
  • Job type: llc-cnftests → stable

2: Run all cnf-compute-llc test tiers on AMD hardware

  • Ginkgo label filter: "uncore-cache" → "tier-0 || tier-1 || tier-2 || uncore-cache"
  • Test suites: functests/13_llc → functests (full suite)
  • Added export BUSY_CPUS_IMAGE=cnf-tests:latest
  • Fixed ${ARTIFACTS_DIR} typo → ${ARTIFACT_DIR}

3: Run only tier-0 and uncore-cache for odd releases every 3 weeks
- Commands script now checks TEST_RUN_FEATURES env var —
- if set, uses it as the label filter; otherwise defaults to all tiers

  • 4.19 and 4.21 configs set TEST_RUN_FEATURES: "tier-0 || uncore-cache"
  • Schedule changed from weekly cron to interval: 504h (every 3 weeks)

Summary by CodeRabbit

This pull request updates OpenShift CI configurations for the openshift-kni/eco-ci-cd repository.

Promote CNF compute LLC 4.22 to stable

The 4.22 test moves from the nightly candidate stream to the stable channel. It uses 4.22 base images, the llc-stable test name, and the stable job type.

Expand AMD test coverage

The test script runs all CNF compute LLC tiers by default and targets the full functests suite. It supports TEST_RUN_FEATURES overrides and sets BUSY_CPUS_IMAGE=cnf-tests:latest. It also corrects ${ARTIFACTS_DIR} to ${ARTIFACT_DIR}.

Schedule focused tests for releases 4.19 and 4.21

The 4.19 and 4.21 jobs run every 504 hours. They use TEST_RUN_FEATURES to limit execution to tier-0 || uncore-cache.

Improve test setup and reports

The script uses the all_fixes branch of the mrniranjan/cluster-node-tuning-operator fork. Report generation removes empty XML files, stops when no reports remain, and merges valid reports before conversion.

mrniranjan and others added 3 commits August 4, 2026 17:52
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Update periodics

Signed-off-by: Niranjan M.R <mniranja@redhat.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci
openshift-ci Bot requested review from dgoodwin and rdiazcam August 4, 2026 12:36
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 6a5aec19-10ce-430b-ad20-b9d47ddaae58

📥 Commits

Reviewing files that changed from the base of the PR and between a30588a and b697367.

📒 Files selected for processing (1)
  • ci-operator/step-registry/telcov10n/functional/cnf-compute/llc/tests/telcov10n-functional-cnf-compute-llc-tests-commands.sh
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/step-registry/telcov10n/functional/cnf-compute/llc/tests/telcov10n-functional-cnf-compute-llc-tests-commands.sh

Walkthrough

This PR updates CNF compute LLC schedules and stable release settings. It changes test feature selection, NTO source defaults, suite coverage, busy CPU image configuration, and XML report processing.

Changes

CNF Compute LLC test flow

Layer / File(s) Summary
Schedule and stable release configuration
ci-operator/config/openshift-kni/eco-ci-cd/...4.19.yaml, ci-operator/config/openshift-kni/eco-ci-cd/...4.21.yaml, ci-operator/config/openshift-kni/eco-ci-cd/...4.22.yaml
The 4.19 and 4.21 configurations use 504-hour intervals and set TEST_RUN_FEATURES. The 4.22 configuration uses 4.22 images, the stable 4.22 channel, and stable test settings.
Test execution setup
ci-operator/step-registry/telcov10n/functional/cnf-compute/llc/tests/telcov10n-functional-cnf-compute-llc-tests-commands.sh
The script uses the forked NTO all_fixes branch by default, supports TEST_RUN_FEATURES, runs the performance-profile suite, and adds BUSY_CPUS_IMAGE.
Report filtering and conversion
ci-operator/step-registry/telcov10n/functional/cnf-compute/llc/tests/telcov10n-functional-cnf-compute-llc-tests-commands.sh
The script removes empty XML reports, merges non-empty reports in ARTIFACT_DIR, generates HTML and JSON reports, and removes temporary XML files.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested labels: rehearsals-ack

Suggested reviewers: dgoodwin, rdiazcam

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Ipv6 And Disconnected Network Test Compatibility ⚠️ Warning The updated runner clones public GitHub repositories, installs Go packages from GitHub, and uses quay.io/openshift-kni; disconnected CI cannot provide these external services. Use internal mirrors or remove external fetches. Verify with /payload-job periodic-ci-openshift-release-master-nightly-4.22-e2e-metal-ipi-ovn-ipv6, or add [Skipped:Disconnected] if unavoidable.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the telcov10 CNF compute LLC test fixes covered by the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The cumulative PR changes only three YAML schedules and one shell runner; no added or modified It, Describe, Context, or When titles were found.
Test Structure And Quality ✅ Passed The PR changes CI YAML and a shell runner only; no Ginkgo It/BeforeEach/AfterEach test implementation is added or modified, so these code-quality checks are not applicable.
Microshift Test Compatibility ✅ Passed The PR adds no Ginkgo test definitions. Its diff contains only CI YAML, Prow scheduling, and a shell wrapper that filters and invokes an external suite; no added MicroShift-incompatible API referen...
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only YAML and shell orchestration; it adds no Go/e2e test source or Ginkgo It/Describe/Context/When declarations, so the SNO check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The PR changes CI/Prow schedules, test labels, images, and reporting only; it adds no deployment manifests, operator code, controllers, or Kubernetes scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR changes only YAML and a Bash wrapper; no OTE Go source, suite setup, or openshift-tests binary invocation is present, so no process-level stdout violation applies.
No-Weak-Crypto ✅ Passed The PR diff contains scheduling, YAML, test-label, image, and report changes only; it adds no weak-crypto algorithms, custom crypto, or secret/token comparisons.
Container-Privileges ✅ Passed The PR adds no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root settings; capabilities: intranet is a Prow job capability.
No-Sensitive-Data-In-Logs ✅ Passed Changed lines log test labels and artifact paths only; sensitive-looking values are absent, and existing set -x/node logging predates this PR.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrniranjan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2026
@mrniranjan

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-kni-eco-ci-cd-main-cnf-compute-llc-5.0-e2e-telcov10n-functional-cnf-compute-llc-nightly

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@mrniranjan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

mrniranjan and others added 2 commits August 5, 2026 05:47
…ate reports

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@mrniranjan

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-kni-eco-ci-cd-main-cnf-compute-llc-5.0-e2e-telcov10n-functional-cnf-compute-llc-nightly

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@mrniranjan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mrniranjan

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-kni-eco-ci-cd-main-cnf-compute-llc-5.0-e2e-telcov10n-functional-cnf-compute-llc-nightly

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@mrniranjan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

mrniranjan and others added 2 commits August 6, 2026 13:51
…row UI

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…llc tests

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@mrniranjan

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-kni-eco-ci-cd-main-cnf-compute-llc-5.0-e2e-telcov10n-functional-cnf-compute-llc-nightly

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@mrniranjan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Signed-off-by: Niranjan M.R <mniranja@redhat.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@mrniranjan: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-compute-llc-5.1-e2e-telcov10n-functional-cnf-compute-llc-nightly N/A periodic Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-compute-llc-4.20-e2e-telcov10n-functional-cnf-compute-llc-stable N/A periodic Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-compute-llc-5.0-e2e-telcov10n-functional-cnf-compute-llc-nightly N/A periodic Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-compute-llc-4.23-e2e-telcov10n-functional-cnf-compute-llc-nightly N/A periodic Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-compute-llc-4.22-e2e-telcov10n-functional-cnf-compute-llc-stable N/A periodic Periodic changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-compute-llc-4.21-e2e-telcov10n-functional-cnf-compute-llc-stable N/A periodic Ci-operator config changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-compute-llc-4.19-e2e-telcov10n-functional-cnf-compute-llc-stable N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

@mrniranjan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mrniranjan

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-kni-eco-ci-cd-main-cnf-compute-llc-5.0-e2e-telcov10n-functional-cnf-compute-llc-nightly

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@mrniranjan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant