Add SNR disconnected periodic and presubmit jobs

[ugreener]

Problem

The medik8s SNR (self-node-remediation) operator has connected E2E testing in Prow but lacks disconnected (air-gapped) testing coverage. Disconnected environments are common in enterprise deployments (banks, governments) where clusters have no internet access. Without disconnected CI, regressions in air-gapped environments go undetected until customer escalation.

Summary

Add a weekly periodic and an optional presubmit job for SNR disconnected E2E testing, reusing the shared medik8s-disconnected chain established in RHWA-840.

Changes

• Add e2e-snr-weekly-aws-disconnected periodic job (Wednesday 12:00 UTC) to the 4.22-disconnected variant config
• Add e2e-snr-aws-disconnected optional presubmit (triggered via /test 4.22-disconnected-e2e-snr-aws-disconnected)
• Scope image mirroring to self-node-remediation and node-healthcheck-operator via MEDIK8S_PACKAGES
• No medik8s-aws-credentials step (SNR uses self-remediation, not AWS fencing)
• Regenerated Prow job files via make jobs

Jira: RHWA-1218

Summary by CodeRabbit

Adds disconnected AWS SNR E2E coverage to the medik8s CI configuration for the 4.22-disconnected variant.

• Adds a weekly Wednesday periodic job.
• Adds an optional presubmit job triggered by /test 4.22-disconnected-e2e-snr-aws-disconnected.
• Reuses the medik8s-disconnected chain.
• Limits mirrored images to self-node-remediation and node-healthcheck-operator.
• Omits AWS fencing credentials because SNR uses self-remediation.
• Regenerates Prow job definitions with make jobs.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: b655cb7b-e636-458c-aea7-e84176c46b69

📥 Commits

Reviewing files that changed from the base of the PR and between 4e80454 and 42355c0.

⛔ Files ignored due to path filters (2)

• ci-operator/jobs/medik8s/system-tests/medik8s-system-tests-main-periodics.yaml is excluded by !ci-operator/jobs/**
• ci-operator/jobs/medik8s/system-tests/medik8s-system-tests-main-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (1)

• ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-disconnected.yaml

---

Walkthrough

The configuration adds optional and weekly disconnected AWS test jobs for SNR. Both jobs enable verbose testing, install the required operators and packages, subscribe to catalogs, run the SNR test command, and use defined resources with a three-hour timeout.

Changes

Disconnected AWS SNR jobs

Layer / File(s)	Summary
Job definitions and schedules ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-disconnected.yaml	Adds the optional e2e-snr-aws-disconnected job and the Wednesday-scheduled e2e-snr-weekly-aws-disconnected job. Both configure SNR testing, operator subscriptions, execution resources, and a three-hour timeout.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the addition of disconnected SNR periodic and presubmit jobs.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The commit changes only YAML CI configuration and generated Prow jobs; no Ginkgo test source or dynamic test title calls are present.
Test Structure And Quality	✅ Passed	The PR changes only three YAML CI/job files and adds no Ginkgo test code or It blocks to review.
Microshift Test Compatibility	✅ Passed	The commit changes only three YAML CI configuration files; it adds no Ginkgo declarations or e2e test source, so the MicroShift API compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The commit changes only ci-operator YAML configuration and generated Prow job files; it adds no Ginkgo tests or multi-node test logic.
Topology-Aware Scheduling Compatibility	✅ Passed	The commit changes only CI-operator configuration and generated Prow job files; it adds no deployment manifests, controllers, replicas, affinity, topology spread, selectors, tolerations, or PDBs.
Ote Binary Stdout Contract	✅ Passed	The PR changes only three declarative YAML job/config files; it adds no OTE binary or suite source where process-level stdout could be introduced.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The pull request changes only YAML job configuration and generated Prow files; it adds no Ginkgo tests or test code to assess for IPv4 assumptions or external connectivity.
No-Weak-Crypto	✅ Passed	The 254 added lines only define disconnected Prow jobs and generated manifests; they contain no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, or custom crypto code.
Container-Privileges	✅ Passed	The added test config and generated Prow Pod specs contain no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root security settings.
No-Sensitive-Data-In-Logs	✅ Passed	Added jobs contain no logging or sensitive-value interpolation; commands only source proxy data, read workload_image, and run tests, while generated jobs reference secret paths without printing sec...

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ugreener

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/medik8s/system-tests/OWNERS [ugreener]
• ci-operator/jobs/medik8s/system-tests/OWNERS [ugreener]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@ugreener: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-medik8s-system-tests-main-4.22-disconnected-e2e-snr-aws-disconnected	medik8s/system-tests	presubmit	Presubmit changed
periodic-ci-medik8s-system-tests-main-4.22-disconnected-e2e-snr-weekly-aws-disconnected	N/A	periodic	Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[ugreener]

/pj-rehearse pull-ci-medik8s-system-tests-main-4.22-disconnected-e2e-snr-aws-disconnected

[openshift-merge-bot]

@ugreener: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@ugreener: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.