ci(check-payload): pass release tag names to payload-scan smoke tests

[smith-xyz]

Summary

• The payload-scan-* smoke tests scan each release image via
  check-payload scan local but discarded the release tag names, so
  tag-scoped config exceptions (e.g. [[tag.agentic-skills.ignore]]) could
  never apply. This broke payload-scan-5-0 on the agentic-skills
  FROM-scratch data-only image, whose exception exists in the embedded 5.0
  config but was unreachable.
• The jq now emits tag=pullspec pairs (with a // "" fallback if a tag
  name is ever missing, preserving scan coverage), and the loop passes
  --tag "$tag" to check-payload scan local. Scan log lines now show the
  tag name alongside the pullspec.

Depends on openshift/check-payload# which adds the --tag flag; merge
that first — older binaries reject the unknown flag.

Summary by CodeRabbit

The OpenShift CI payload-scan-* smoke tests now preserve release image tags during local payload scans. Each scan passes the tag through --tag "$tag" and logs it with the pullspec. This enables tag-scoped configuration exceptions, including [[tag.agentic-skills.ignore]], while using an empty tag when no tag exists.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: dee0f4a5-8d6f-4ff4-b118-15707920931f

📥 Commits

Reviewing files that changed from the base of the PR and between d3c6320 and 226dc38.

📒 Files selected for processing (1)

• ci-operator/config/openshift/check-payload/openshift-check-payload-main.yaml

---

Walkthrough

The payload scan jobs now preserve image tags with image pull specifications. Each job logs both values and passes the tag to /check-payload scan local for the 4.12, 4.15, 4.20, and 5.0 payloads.

Changes

Payload scan tag propagation

Layer / File(s)	Summary
Tag-aware payload scans ci-operator/config/openshift/check-payload/openshift-check-payload-main.yaml	The 4.12, 4.15, 4.20, and 5.0 jobs parse tag=image pairs, log both values, and pass --tag to /check-payload scan local.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: passing release tag names to payload-scan smoke tests.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The only changed file is YAML with static Prow test identifiers; it adds no Ginkgo title calls or dynamic test names.
Test Structure And Quality	✅ Passed	The PR changes only one YAML CI configuration file; it adds shell payload-scan jobs and contains no Ginkgo test code or It blocks to assess.
Microshift Test Compatibility	✅ Passed	This PR modifies a CI configuration file (openshift-check-payload-main.yaml) with shell script commands for payload scanning. It does not add any Ginkgo e2e tests, so the MicroShift Test Compatibil...
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The commit changes only one CI YAML file and adds no Ginkgo e2e tests, so SNO multi-node compatibility checks do not apply.
Topology-Aware Scheduling Compatibility	✅ Passed	The YAML changes only payload-scan shell commands, tag parsing, logging, and --tag; no deployment or topology-sensitive scheduling constraints are introduced.
Ote Binary Stdout Contract	✅ Passed	The PR changes only a YAML shell command. It adds no OTE binary or suite code; its echo output is job logging, not process-level openshift-tests stdout.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR changes only YAML payload-scan shell commands. It adds no Ginkgo e2e tests, IPv4 assumptions, or new external connectivity requirements.
No-Weak-Crypto	✅ Passed	The commit only changes YAML shell loops for image tags and scan arguments; it adds no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons.
Container-Privileges	✅ Passed	The modified YAML file contains no privilege escalation indicators: no privileged mode, hostPID/hostNetwork/hostIPC, SYS_ADMIN capabilities, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	The changes log only public image metadata: component tag names (agentic-skills, network-operator) and public pullspecs from quay.io. No passwords, tokens, API keys, PII, session IDs, internal host...

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[smith-xyz]

complimentary to openshift/check-payload#356

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@smith-xyz: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-check-payload-main-payload-scan-4-12	openshift/check-payload	presubmit	Ci-operator config changed
pull-ci-openshift-check-payload-main-payload-scan-4-15	openshift/check-payload	presubmit	Ci-operator config changed
pull-ci-openshift-check-payload-main-payload-scan-4-20	openshift/check-payload	presubmit	Ci-operator config changed
pull-ci-openshift-check-payload-main-payload-scan-5-0	openshift/check-payload	presubmit	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[smith-xyz]

/pj-rehearse auto-ack

[openshift-merge-bot]

@smith-xyz: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[richardsonnick]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsonnick, smith-xyz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/check-payload/OWNERS [richardsonnick,smith-xyz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@smith-xyz: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.