Skip to content

setup assisted-installer version v2.55 - #83053

Open
danmanor wants to merge 1 commit into
openshift:mainfrom
danmanor:assisted-installer/setup-version-v2.55-145ed6bb-9d4c-4eed-b403-282af8d50db2
Open

setup assisted-installer version v2.55#83053
danmanor wants to merge 1 commit into
openshift:mainfrom
danmanor:assisted-installer/setup-version-v2.55-145ed6bb-9d4c-4eed-b403-282af8d50db2

Conversation

@danmanor

@danmanor danmanor commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Configures OpenShift CI for Assisted Installer and Assisted Installer Agent v2.55.
  • Updates subsystem-test and e2e-metal-assisted to use pipeline_skip_if_only_changed.
  • Sets these tests to always_run: false, so they can be skipped when only unrelated files change.
  • Keeps the existing e2e-metal-assisted filter and workflow unchanged.

@openshift-ci

openshift-ci Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2026
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 036eb579-82a6-4876-b605-2bdb80a4042c

📥 Commits

Reviewing files that changed from the base of the PR and between 658e1ba and 38d0435.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.55-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (2)
  • ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.55.yaml

Walkthrough

The Assisted Installer test configurations now set selected tests to always_run: false and use pipeline_skip_if_only_changed instead of skip_if_only_changed. Existing filter expressions and workflows remain unchanged.

Changes

Assisted Installer CI configuration

Layer / File(s) Summary
Update Assisted Installer test triggers
ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55.yaml, ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.55.yaml
The configurations disable unconditional execution for the affected tests and replace skip_if_only_changed with pipeline_skip_if_only_changed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the assisted-installer v2.55 setup, which matches the main changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The commit changes only static CI configuration and presubmit metadata; it adds no Ginkgo It/Describe/Context/When titles or dynamic test-name values.
Test Structure And Quality ✅ Passed The commit changes only four CI YAML files; no Ginkgo test code, It blocks, resource setup, waits, or assertions changed, so this check is not applicable.
Microshift Test Compatibility ✅ Passed The pull request changes only YAML CI configuration and generated presubmit files; it adds no Ginkgo e2e tests or MicroShift-incompatible API references.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The commit changes only four YAML CI configuration files; it adds no Go or Ginkgo test declarations, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The commit changes only CI test/job configuration: always_run and change-filter fields. It adds no deployment, operator, controller, or topology scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The commit changes only four YAML CI configuration/job files; it adds no OTE binary or process-level Go code, so the stdout contract is not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The patch changes only CI YAML configuration and generated presubmit YAML; it adds no Ginkgo e2e tests, IPv4 assumptions, or external connectivity calls.
No-Weak-Crypto ✅ Passed The PR changes only CI YAML scheduling fields and generated annotations; the added lines contain no weak algorithms, crypto implementations, or secret comparisons.
Container-Privileges ✅ Passed The four changed YAML files add only scheduling fields; no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings are present.
No-Sensitive-Data-In-Logs ✅ Passed The commit changes CI scheduling filters and generated annotations only; it adds no logging or sensitive-data output. Existing token mounts and references are unchanged.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@danmanor: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-assisted-installer-v2.55-e2e-metal-assisted openshift/assisted-installer presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-agent-v2.55-e2e-metal-assisted openshift/assisted-installer-agent presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-agent-v2.55-subsystem-test openshift/assisted-installer-agent presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

@danmanor: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants