Remove approved as a required label, only require lgtm

[jfrazierRedHat]

Summary by CodeRabbit

• Updates Prow merge readiness for openshift-online/rosa-backend-tests.
• Removes approved as a required label.
• Configures lgtm to act as approval, making it the only required label.

[coderabbitai]

Warning

Review limit reached

@jfrazierRedHat, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 4 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: e9f29b26-2ee6-433a-a7e7-01a69d3b53c4

📥 Commits

Reviewing files that changed from the base of the PR and between d5af654 and 65c23b3.

📒 Files selected for processing (1)

• core-services/prow/02_config/openshift-online/rosa-backend-tests/_pluginconfig.yaml

Walkthrough

The Prow configuration for openshift-online/rosa-backend-tests now treats lgtm as approval. The Tide query no longer requires the approved label.

Changes

ROSA backend approval configuration

Layer / File(s)	Summary
Align approval and Tide requirements core-services/prow/02_config/openshift-online/rosa-backend-tests/_pluginconfig.yaml, core-services/prow/02_config/openshift-online/rosa-backend-tests/_prowconfig.yaml	The approve plugin enables lgtm_acts_as_approve. The Tide query requires only the lgtm label.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested labels: lgtm

Suggested reviewers: lir10, ssukanmi

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: removing the required approved label and requiring only lgtm.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The patch changes only two YAML Prow configuration files; it adds or removes no Ginkgo test-title calls or dynamic test names.
Test Structure And Quality	✅ Passed	The commit changes only two YAML configuration files; it contains no Ginkgo constructs or test files, so the Ginkgo test quality check is not applicable.
Microshift Test Compatibility	✅ Passed	The PR changes only two Prow YAML files; the parent diff adds no Ginkgo e2e tests, so MicroShift compatibility checks do not apply.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The commit changes only two YAML configuration files and adds no Ginkgo tests, Go files, or multi-node assumptions; the SNO check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	The commit changes only two Prow YAML files for label approval; it adds no deployment manifests, operator code, controllers, or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The diff changes only two Prow YAML configuration files; it changes no OTE binary or process-level code and adds no stdout writes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The pull request changes only two YAML Prow configuration files. It adds no Ginkgo e2e tests, IPv4 assumptions, or external connectivity requirements.
No-Weak-Crypto	✅ Passed	The commit changes only Prow YAML labels and approval settings; it adds no cryptographic algorithms, modes, custom crypto, or secret comparisons.
Container-Privileges	✅ Passed	The PR changes only Prow label and approval configuration; the exact patch contains no container or Kubernetes privilege settings.
No-Sensitive-Data-In-Logs	✅ Passed	The commit changes only Tide and approve YAML settings. Added lines contain no logging statements, credentials, tokens, PII, hostnames, or customer data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[jfrazierRedHat]

/retest

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@jfrazierRedHat: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@jfrazierRedHat: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[dustman9000]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustman9000, jfrazierRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• core-services/prow/02_config/openshift-online/rosa-backend-tests/OWNERS [jfrazierRedHat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment