Skip to content

NO-JIRA: fix: add nested_podman:true annotation in cryptoscan ref - #83085

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
fracappa:fca/propagate-cryptoscan-in-main-rebase
Aug 7, 2026
Merged

NO-JIRA: fix: add nested_podman:true annotation in cryptoscan ref#83085
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
fracappa:fca/propagate-cryptoscan-in-main-rebase

Conversation

@fracappa

@fracappa fracappa commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Enables nested Podman for the MicroShift rebase crypto-scan step.
  • This allows the OpenShift CI job to run crypto scanning in a nested Podman environment.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 7, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@fracappa: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from jogeo and qJkee August 7, 2026 08:29
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: f6164a6c-5b62-422f-87f1-cf28b5221c16

📥 Commits

Reviewing files that changed from the base of the PR and between f85f4e1 and 343c0ae.

📒 Files selected for processing (1)
  • ci-operator/step-registry/openshift/microshift/rebase/cryptoscan/openshift-microshift-rebase-cryptoscan-ref.yaml

Walkthrough

The MicroShift rebase cryptoscan step now enables nested Podman execution through its step configuration.

Changes

MicroShift cryptoscan configuration

Layer / File(s) Summary
Nested Podman configuration
ci-operator/step-registry/openshift/microshift/rebase/cryptoscan/openshift-microshift-rebase-cryptoscan-ref.yaml
The cryptoscan step sets nested_podman: true.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: adding the nested_podman:true annotation to the cryptoscan reference.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The patch only adds the static YAML field nested_podman: true; it introduces no Ginkgo tests or dynamic test titles.
Test Structure And Quality ✅ Passed The pull request changes only one YAML reference by adding nested_podman: true; it adds no Ginkgo tests or cluster operations to review.
Microshift Test Compatibility ✅ Passed The commit adds only nested_podman: true to a YAML step reference; it adds no Ginkgo tests, APIs, resources, namespaces, or MicroShift assumptions.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The commit changes only one YAML declaration by adding nested_podman: true; it adds no Ginkgo e2e tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The changed file is a CI step reference. Its only scheduling-relevant change is nested_podman: true; it adds no replicas, affinity, spread constraints, selectors, tolerations, or PDBs.
Ote Binary Stdout Contract ✅ Passed The PR adds only nested_podman: true to a YAML step reference; it changes no OTE binary or process-level stdout code.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The pull request adds only nested_podman: true to a YAML step reference and adds no Ginkgo tests or network operations.
No-Weak-Crypto ✅ Passed The PR adds only nested_podman: true; it introduces no weak algorithm, custom crypto, or secret comparison.
Container-Privileges ✅ Passed The only PR change is nested_podman: true; the affected reference has none of the listed privilege fields, and its image definition switches to USER 1000.
No-Sensitive-Data-In-Logs ✅ Passed The PR changes only a YAML annotation, nested_podman: true; it adds no logging or secret-bearing output, and the command script is unchanged.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@fracappa: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-microshift-main-test-rebase openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-5.0-test-rebase openshift/microshift presubmit Registry content changed
periodic-ci-openshift-microshift-release-5.1-periodics-rebase-on-nightlies N/A periodic Registry content changed
periodic-ci-openshift-microshift-release-5.0-periodics-rebase-on-nightlies N/A periodic Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

@fracappa: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pacevedom pacevedom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@pacevedom

Copy link
Copy Markdown
Contributor

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@pacevedom: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 7, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2026
@openshift-ci

openshift-ci Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fracappa, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 288ee94 into openshift:main Aug 7, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants