Add 16 informing jobs to 4.23 nightly release controller config - #83105
Add 16 informing jobs to 4.23 nightly release controller config#83105redhat-chai-bot wants to merge 1 commit into
Conversation
Adds the following informing jobs to the 4.23.0-0.nightly release stream, matching the configurations present in the 4.22 nightly stream: Metal upgrades + dualstack: - metal-ipi-ovn-upgrade (micro) - metal-ipi-ovn-upgrade-minor (from 4.22) - metal-ipi-upgrade-ovn-ipv6 (micro) - metal-ipi-upgrade-ovn-ipv6-minor (from 4.22) - metal-ipi-ovn-dualstack (base e2e) vSphere upgrades: - vsphere-ovn-upgrade-micro - vsphere-ovn-upgrade-minor (from 4.22) Azure TechPreview: - azure-ovn-techpreview - azure-ovn-techpreview-serial-1of2 - azure-ovn-techpreview-serial-2of2 GCP TechPreview: - gcp-ovn-techpreview - gcp-ovn-techpreview-serial-1of2 - gcp-ovn-techpreview-serial-2of2 AWS SNO: - aws-ovn-single-node-upgrade-minor (from 4.22) - aws-ovn-single-node-techpreview - aws-ovn-single-node-techpreview-serial All entries are optional informing jobs with no maxRetries, matching the 4.22 configuration pattern. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( |
WalkthroughThe 4.23 release verification configuration adds AWS, Azure, GCP, metal, vSphere, Hypershift, and FIPS verification jobs. Upgrade entries include 4.22 source metadata, retry settings, and applicable qualifiers. ChangesOCP 4.23 verification configuration
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: redhat-chai-bot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Caution CodeRabbit couldn't update its existing comment. The review summary may be out of date. Error details |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@core-services/release-controller/_releases/release-ocp-4.23.json`:
- Line 23: Remove the maxRetries property from the informing jobs
aws-ovn-serial-1of2, aws-ovn-serial-2of2,
aws-ovn-single-node-upgrade-4.23-micro, aws-ovn-techpreview,
aws-ovn-techpreview-serial-1of3, aws-ovn-techpreview-serial-2of3,
aws-ovn-techpreview-serial-3of3, fips-scan, hypershift-ovn-conformance-4.23,
metal-ipi-ovn-ipv4, and metal-ipi-ovn-ipv6 in
core-services/release-controller/_releases/release-ocp-4.23.json at lines 23,
30, 49, 70, 77, 84, 91, 142, 184, 197, and 204.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: e1705c13-fccc-4ca9-9a20-124c1de5cd95
📒 Files selected for processing (1)
core-services/release-controller/_releases/release-ocp-4.23.json
| "verify": { | ||
| "aws-ovn-serial-1of2": { | ||
| "optional": true, | ||
| "maxRetries": 1, |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Remove retry settings from the new informing jobs.
The PR objective requires all added entries to omit maxRetries. These entries configure retries and do not meet that requirement.
core-services/release-controller/_releases/release-ocp-4.23.json#L23-L23: RemovemaxRetriesfromaws-ovn-serial-1of2.core-services/release-controller/_releases/release-ocp-4.23.json#L30-L30: RemovemaxRetriesfromaws-ovn-serial-2of2.core-services/release-controller/_releases/release-ocp-4.23.json#L49-L49: RemovemaxRetriesfromaws-ovn-single-node-upgrade-4.23-micro.core-services/release-controller/_releases/release-ocp-4.23.json#L70-L70: RemovemaxRetriesfromaws-ovn-techpreview.core-services/release-controller/_releases/release-ocp-4.23.json#L77-L77: RemovemaxRetriesfromaws-ovn-techpreview-serial-1of3.core-services/release-controller/_releases/release-ocp-4.23.json#L84-L84: RemovemaxRetriesfromaws-ovn-techpreview-serial-2of3.core-services/release-controller/_releases/release-ocp-4.23.json#L91-L91: RemovemaxRetriesfromaws-ovn-techpreview-serial-3of3.core-services/release-controller/_releases/release-ocp-4.23.json#L142-L142: RemovemaxRetriesfromfips-scan.core-services/release-controller/_releases/release-ocp-4.23.json#L184-L184: RemovemaxRetriesfromhypershift-ovn-conformance-4.23.core-services/release-controller/_releases/release-ocp-4.23.json#L197-L197: RemovemaxRetriesfrommetal-ipi-ovn-ipv4.core-services/release-controller/_releases/release-ocp-4.23.json#L204-L204: RemovemaxRetriesfrommetal-ipi-ovn-ipv6.
📍 Affects 1 file
core-services/release-controller/_releases/release-ocp-4.23.json#L23-L23(this comment)core-services/release-controller/_releases/release-ocp-4.23.json#L30-L30core-services/release-controller/_releases/release-ocp-4.23.json#L49-L49core-services/release-controller/_releases/release-ocp-4.23.json#L70-L70core-services/release-controller/_releases/release-ocp-4.23.json#L77-L77core-services/release-controller/_releases/release-ocp-4.23.json#L84-L84core-services/release-controller/_releases/release-ocp-4.23.json#L91-L91core-services/release-controller/_releases/release-ocp-4.23.json#L142-L142core-services/release-controller/_releases/release-ocp-4.23.json#L184-L184core-services/release-controller/_releases/release-ocp-4.23.json#L197-L197core-services/release-controller/_releases/release-ocp-4.23.json#L204-L204
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@core-services/release-controller/_releases/release-ocp-4.23.json` at line 23,
Remove the maxRetries property from the informing jobs aws-ovn-serial-1of2,
aws-ovn-serial-2of2, aws-ovn-single-node-upgrade-4.23-micro,
aws-ovn-techpreview, aws-ovn-techpreview-serial-1of3,
aws-ovn-techpreview-serial-2of3, aws-ovn-techpreview-serial-3of3, fips-scan,
hypershift-ovn-conformance-4.23, metal-ipi-ovn-ipv4, and metal-ipi-ovn-ipv6 in
core-services/release-controller/_releases/release-ocp-4.23.json at lines 23,
30, 49, 70, 77, 84, 91, 142, 184, 197, and 204.
|
@redhat-chai-bot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Adds the following informing jobs to the 4.23.0-0.nightly release stream, matching the configurations present in the 4.22 nightly stream:
Metal upgrades + dualstack
metal-ipi-ovn-upgrade(micro)metal-ipi-ovn-upgrade-minor(from 4.22)metal-ipi-upgrade-ovn-ipv6(micro)metal-ipi-upgrade-ovn-ipv6-minor(from 4.22)metal-ipi-ovn-dualstack(base e2e)vSphere upgrades
vsphere-ovn-upgrade-microvsphere-ovn-upgrade-minor(from 4.22)Azure TechPreview
azure-ovn-techpreviewazure-ovn-techpreview-serial-1of2azure-ovn-techpreview-serial-2of2GCP TechPreview
gcp-ovn-techpreviewgcp-ovn-techpreview-serial-1of2gcp-ovn-techpreview-serial-2of2AWS SNO
aws-ovn-single-node-upgrade-minor(from 4.22)aws-ovn-single-node-techpreviewaws-ovn-single-node-techpreview-serialAll entries are optional informing jobs with no
maxRetries, matching the 4.22 configuration pattern. All corresponding periodic Prow jobs already exist in the ci-operator configs.AI-generated. Review for accuracy.
@neisw requested via Chai Bot
Summary by CodeRabbit
Updates the OpenShift 4.23 nightly release verification configuration with 16 optional informing jobs. The jobs cover Metal, dual-stack, vSphere, Azure TechPreview, GCP TechPreview, Hypershift, and AWS single-node scenarios.
The configuration adds upgrade metadata, including
4.22source releases and FIPS qualifiers, where required. It preserves existing Prow job names and options. All new entries omitmaxRetries.