Add 4.22 OKD configs - #83137
Open
jatinsu wants to merge 1 commit into
Open
Conversation
Contributor
WalkthroughAdds generated OKD SCOS 4.22 CI release configurations for many OpenShift components. The changes define image builds, promotion, release integration, resources, optional AWS OVN tests, repository metadata, and image-mirroring mappings. Two main configurations move to SCOS 5.0. ChangesOKD SCOS 4.22 release enablement
Estimated code review effort: 4 (Complex) | ~60 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
|
Contributor
Contributor
|
[REHEARSALNOTIFIER]
A total of 328 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/cloud-provider-aws/openshift-cloud-provider-aws-release-4.22__okd-scos.yaml`:
- Around line 43-49: Regenerate and commit the deterministic CI artifacts for
the new e2e-aws-ovn test by running make update. This must update the generated
Prow job and metadata outputs for
ci-operator/config/openshift/cloud-provider-aws/openshift-cloud-provider-aws-release-4.22__okd-scos.yaml:43-49,
cloud-provider-azure/openshift-cloud-provider-azure-release-4.22__okd-scos.yaml:54-60,
cloud-provider-gcp/openshift-cloud-provider-gcp-release-4.22__okd-scos.yaml:43-49,
cloud-provider-ibm/openshift-cloud-provider-ibm-release-4.22__okd-scos.yaml:43-49,
cloud-provider-kubevirt/openshift-cloud-provider-kubevirt-release-4.22__okd-scos.yaml:43-49,
kubernetes-metrics-server/openshift-kubernetes-metrics-server-release-4.22__okd-scos.yaml:43-49,
kubernetes/openshift-kubernetes-release-4.22__okd-scos.yaml:77-83,
kubevirt-csi-driver/openshift-kubevirt-csi-driver-release-4.22__okd-scos.yaml:43-49,
machine-api-operator/openshift-machine-api-operator-release-4.22__okd-scos.yaml:43-49,
machine-api-provider-aws/openshift-machine-api-provider-aws-release-4.22__okd-scos.yaml:43-49,
machine-api-provider-azure/openshift-machine-api-provider-azure-release-4.22__okd-scos.yaml:43-49,
and
machine-api-provider-gcp/openshift-machine-api-provider-gcp-release-4.22__okd-scos.yaml:43-49;
commit all generated changes.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Comment on lines
+43
to
+49
| tests: | ||
| - always_run: false | ||
| as: e2e-aws-ovn | ||
| optional: true | ||
| steps: | ||
| cluster_profile: openshift-org-aws | ||
| workflow: openshift-e2e-aws |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Regenerate and commit CI artifacts for the new tests.
These new named tests change CI job structure. The supplied change has no regenerated Prow job or metadata output. Run make update and commit the deterministic generated changes before merge.
ci-operator/config/openshift/cloud-provider-aws/openshift-cloud-provider-aws-release-4.22__okd-scos.yaml#L43-L49: regenerate the job fore2e-aws-ovn.ci-operator/config/openshift/cloud-provider-azure/openshift-cloud-provider-azure-release-4.22__okd-scos.yaml#L54-L60: regenerate the job fore2e-aws-ovn.ci-operator/config/openshift/cloud-provider-gcp/openshift-cloud-provider-gcp-release-4.22__okd-scos.yaml#L43-L49: regenerate the job fore2e-aws-ovn.ci-operator/config/openshift/cloud-provider-ibm/openshift-cloud-provider-ibm-release-4.22__okd-scos.yaml#L43-L49: regenerate the job fore2e-aws-ovn.ci-operator/config/openshift/cloud-provider-kubevirt/openshift-cloud-provider-kubevirt-release-4.22__okd-scos.yaml#L43-L49: regenerate the job fore2e-aws-ovn.ci-operator/config/openshift/kubernetes-metrics-server/openshift-kubernetes-metrics-server-release-4.22__okd-scos.yaml#L43-L49: regenerate the job fore2e-aws-ovn.ci-operator/config/openshift/kubernetes/openshift-kubernetes-release-4.22__okd-scos.yaml#L77-L83: regenerate the job fore2e-aws-ovn.ci-operator/config/openshift/kubevirt-csi-driver/openshift-kubevirt-csi-driver-release-4.22__okd-scos.yaml#L43-L49: regenerate the job fore2e-aws-ovn.ci-operator/config/openshift/machine-api-operator/openshift-machine-api-operator-release-4.22__okd-scos.yaml#L43-L49: regenerate the job fore2e-aws-ovn.ci-operator/config/openshift/machine-api-provider-aws/openshift-machine-api-provider-aws-release-4.22__okd-scos.yaml#L43-L49: regenerate the job fore2e-aws-ovn.ci-operator/config/openshift/machine-api-provider-azure/openshift-machine-api-provider-azure-release-4.22__okd-scos.yaml#L43-L49: regenerate the job fore2e-aws-ovn.ci-operator/config/openshift/machine-api-provider-gcp/openshift-machine-api-provider-gcp-release-4.22__okd-scos.yaml#L43-L49: regenerate the job fore2e-aws-ovn.
As per coding guidelines, “When modifying CI jobs in ci-operator/config/, run make update to validate config, generate Prow job configs, and sanitize job definitions.”
📍 Affects 12 files
ci-operator/config/openshift/cloud-provider-aws/openshift-cloud-provider-aws-release-4.22__okd-scos.yaml#L43-L49(this comment)ci-operator/config/openshift/cloud-provider-azure/openshift-cloud-provider-azure-release-4.22__okd-scos.yaml#L54-L60ci-operator/config/openshift/cloud-provider-gcp/openshift-cloud-provider-gcp-release-4.22__okd-scos.yaml#L43-L49ci-operator/config/openshift/cloud-provider-ibm/openshift-cloud-provider-ibm-release-4.22__okd-scos.yaml#L43-L49ci-operator/config/openshift/cloud-provider-kubevirt/openshift-cloud-provider-kubevirt-release-4.22__okd-scos.yaml#L43-L49ci-operator/config/openshift/kubernetes-metrics-server/openshift-kubernetes-metrics-server-release-4.22__okd-scos.yaml#L43-L49ci-operator/config/openshift/kubernetes/openshift-kubernetes-release-4.22__okd-scos.yaml#L77-L83ci-operator/config/openshift/kubevirt-csi-driver/openshift-kubevirt-csi-driver-release-4.22__okd-scos.yaml#L43-L49ci-operator/config/openshift/machine-api-operator/openshift-machine-api-operator-release-4.22__okd-scos.yaml#L43-L49ci-operator/config/openshift/machine-api-provider-aws/openshift-machine-api-provider-aws-release-4.22__okd-scos.yaml#L43-L49ci-operator/config/openshift/machine-api-provider-azure/openshift-machine-api-provider-azure-release-4.22__okd-scos.yaml#L43-L49ci-operator/config/openshift/machine-api-provider-gcp/openshift-machine-api-provider-gcp-release-4.22__okd-scos.yaml#L43-L49
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/cloud-provider-aws/openshift-cloud-provider-aws-release-4.22__okd-scos.yaml`
around lines 43 - 49, Regenerate and commit the deterministic CI artifacts for
the new e2e-aws-ovn test by running make update. This must update the generated
Prow job and metadata outputs for
ci-operator/config/openshift/cloud-provider-aws/openshift-cloud-provider-aws-release-4.22__okd-scos.yaml:43-49,
cloud-provider-azure/openshift-cloud-provider-azure-release-4.22__okd-scos.yaml:54-60,
cloud-provider-gcp/openshift-cloud-provider-gcp-release-4.22__okd-scos.yaml:43-49,
cloud-provider-ibm/openshift-cloud-provider-ibm-release-4.22__okd-scos.yaml:43-49,
cloud-provider-kubevirt/openshift-cloud-provider-kubevirt-release-4.22__okd-scos.yaml:43-49,
kubernetes-metrics-server/openshift-kubernetes-metrics-server-release-4.22__okd-scos.yaml:43-49,
kubernetes/openshift-kubernetes-release-4.22__okd-scos.yaml:77-83,
kubevirt-csi-driver/openshift-kubevirt-csi-driver-release-4.22__okd-scos.yaml:43-49,
machine-api-operator/openshift-machine-api-operator-release-4.22__okd-scos.yaml:43-49,
machine-api-provider-aws/openshift-machine-api-provider-aws-release-4.22__okd-scos.yaml:43-49,
machine-api-provider-azure/openshift-machine-api-provider-azure-release-4.22__okd-scos.yaml:43-49,
and
machine-api-provider-gcp/openshift-machine-api-provider-gcp-release-4.22__okd-scos.yaml:43-49;
commit all generated changes.
Source: Coding guidelines
Contributor
|
@jatinsu: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These 4.22 Configs for OKD were generated via a skill found here
Summary by CodeRabbit
origin_scos-4.22image mirroring from 4 to 196 component mappings.oc-mirrorimage mappings for SCOS 5.0.oc-mirrormain configurations from SCOS 4.22 to SCOS 5.0.