Skip to content

Removed version and channel from cert-manager - #83154

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
hector-vido:agnostic-cert-manager
Aug 10, 2026
Merged

Removed version and channel from cert-manager#83154
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
hector-vido:agnostic-cert-manager

Conversation

@hector-vido

@hector-vido hector-vido commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Removing version and channel from Subscription allows Openshift to select the default stable channel and version, making the onboard of new clusters easier since a fixed version can become unavailable for new releases of Openshift.

Summary by CodeRabbit

The cert-manager operator Subscription no longer pins a channel or starting version. OpenShift can select the default stable channel and version, which simplifies cluster onboarding when a fixed version is unavailable.

@openshift-ci
openshift-ci Bot requested review from bear-redhat and pruan-rht August 9, 2026 19:11
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 9, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@hector-vido: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: fec0fe85-1b39-4d84-b902-8d2f29df2240

📥 Commits

Reviewing files that changed from the base of the PR and between 6fd6d16 and 153a3f8.

📒 Files selected for processing (1)
  • clusters/build-clusters/build-shared/cert-manager-operator/operator.yaml
💤 Files with no reviewable changes (1)
  • clusters/build-clusters/build-shared/cert-manager-operator/operator.yaml

Walkthrough

The cert-manager operator subscription no longer sets an explicit channel or startingCSV. Automatic approval and operator source settings remain unchanged.

Changes

Cert-manager subscription

Layer / File(s) Summary
Subscription configuration
clusters/build-clusters/build-shared/cert-manager-operator/operator.yaml
Removes the stable-v1 channel and startingCSV fields. Retains automatic approval, operator name, source, and source namespace.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: removing the version and channel fields from the cert-manager Subscription.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only a YAML Subscription; it adds or modifies no Ginkgo test titles or test files.
Test Structure And Quality ✅ Passed The pull request changes only the cert-manager Subscription manifest and adds or modifies no Ginkgo test code, so these test-quality requirements are not applicable.
Microshift Test Compatibility ✅ Passed The commit changes only Subscription YAML fields and adds no Ginkgo e2e tests, so MicroShift test compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull request changes only a Subscription manifest and adds no Ginkgo e2e tests or node-topology assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The commit only removes channel and startingCSV from the Subscription; the manifest adds no replicas, affinity, topology spread, node selector, toleration, or other scheduling constraint.
Ote Binary Stdout Contract ✅ Passed The PR changes only one Subscription YAML manifest and adds no OTE binary or process-level code; the stdout contract is not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The pull request changes only a Subscription YAML and adds no Ginkgo e2e tests, IPv4 assumptions, or external connectivity requirements.
No-Weak-Crypto ✅ Passed The PR only deletes Subscription channel and startingCSV fields; it adds no cryptographic code or references to weak algorithms, custom crypto, or secret comparisons.
Container-Privileges ✅ Passed The PR changes only Subscription channel and startingCSV. The target manifest contains no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The commit only removes Subscription channel and startingCSV fields; it adds no logging statements or sensitive values.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2026
@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepsm007, hector-vido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

@hector-vido: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 2815cff into openshift:main Aug 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants