NetObserv: use src image for evaluate-failures step

[jpinsonneau]

Summary

• Switch netobserv-evaluate-failures from e2etests to src so the step works in all NetObserv jobs (e.g. netobserv-web-console), which do not build/import e2etests.
• Fixes ImagePullBackOff (manifest unknown for stable:e2etests) after otherwise successful integration tests.

Test plan

• /pj-rehearse pull-ci-netobserv-netobserv-web-console-main-integration-tests
• Confirm integration-tests-netobserv-evaluate-failures starts without ImagePullBackOff and exits cleanly

Made with Cursor

Summary by CodeRabbit

• Updated the NetObserv netobserv-evaluate-failures CI step to use the src image.
• This allows the step to run in all NetObserv jobs, including netobserv-web-console, without requiring the unavailable e2etests image.
• Prevents ImagePullBackOff errors caused by the missing stable:e2etests manifest.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: f8b398f9-73ac-4c8d-a4d7-e07f9e277529

📥 Commits

Reviewing files that changed from the base of the PR and between 9be95ee and 727bec6.

📒 Files selected for processing (1)

• ci-operator/step-registry/netobserv/evaluate-failures/netobserv-evaluate-failures-ref.yaml

---

Walkthrough

The NetObserv failure evaluation step now uses the src image. Its command, resources, and documentation remain unchanged.

Changes

NetObserv image update

Layer / File(s)	Summary
Update step image source ci-operator/step-registry/netobserv/evaluate-failures/netobserv-evaluate-failures-ref.yaml	The step changes its image source from e2etests to src. The command and resources remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: using the src image for the NetObserv evaluate-failures step.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR changes only a YAML image reference and comments; no Ginkgo test files or It/Describe/Context/When titles are added or modified.
Test Structure And Quality	✅ Passed	Not applicable: the pull request changes only one YAML step reference; it adds or modifies no Ginkgo test code.
Microshift Test Compatibility	✅ Passed	The commit changes only one step-registry YAML file from e2etests to src; it adds no Ginkgo tests or MicroShift-incompatible API references.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR changes only one YAML step definition from e2etests to src; it adds no Ginkgo tests or multi-node assumptions, so the SNO check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	The commit only changes the step image from e2etests to src and adds comments; it adds no affinity, topology spread, selector, toleration, replica, or PDB scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The PR changes only a step YAML image reference and comments; no OTE binary or process-level Go suite code is added or modified.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR changes only a step YAML image reference; it adds no Ginkgo tests, IPv4 assumptions, or external connectivity.
No-Weak-Crypto	✅ Passed	The PR only changes the step image from e2etests to src; the diff and referenced shell script contain no weak algorithms, custom crypto, or secret comparisons.
Container-Privileges	✅ Passed	The changed step reference only switches from to src; it contains no privileged, host namespace, SYS_ADMIN, or privilege-escalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	The PR changes only the image reference and comments; the evaluator logs fixed step names and exit codes, and no passwords, tokens, PII, hostnames, or customer data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/step-registry/netobserv/OWNERS [jpinsonneau]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@jpinsonneau: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-netobserv-netobserv-ebpf-agent-main-qe-e2e-tests	netobserv/netobserv-ebpf-agent	presubmit	Registry content changed
pull-ci-netobserv-flowlogs-pipeline-main-qe-e2e-tests	netobserv/flowlogs-pipeline	presubmit	Registry content changed
pull-ci-netobserv-netobserv-web-console-main-integration-tests	netobserv/netobserv-web-console	presubmit	Registry content changed
pull-ci-netobserv-netobserv-web-console-main-pf5-pf5-integration-tests	netobserv/netobserv-web-console	presubmit	Registry content changed
pull-ci-netobserv-netobserv-web-console-main-pf4-pf4-integration-tests	netobserv/netobserv-web-console	presubmit	Registry content changed
pull-ci-netobserv-netobserv-operator-main-e2etest	netobserv/netobserv-operator	presubmit	Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-5.1-netobserv-azure-ipi-amd-f7	N/A	periodic	Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.14-netobserv-aws-ipi-amd-f60	N/A	periodic	Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-5.1-netobserv-gcp-ipi-amd-f7	N/A	periodic	Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-5.1-netobserv-aws-ipi-arm-f28	N/A	periodic	Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.14-netobserv-aws-ipi-arm-f60	N/A	periodic	Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.22-netobserv-metal-ds-ipi-ovn-dualstack-primaryv6-f28-ipv6	N/A	periodic	Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-5.1-netobserv-metal-ds-ipi-ovn-dualstack-primaryv6-f28-ipv6	N/A	periodic	Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.18-netobserv-azure-ipi-amd-f14	N/A	periodic	Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-5.0-netobserv-metal-ds-ipi-ovn-dualstack-primaryv6-f28-ipv6	N/A	periodic	Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-5.0-netobserv-azure-ipi-amd-f7	N/A	periodic	Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.21-netobserv-metal-ds-ipi-ovn-dualstack-primaryv6-f28-ipv6	N/A	periodic	Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.16-netobserv-aws-ipi-amd-f28	N/A	periodic	Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.16-netobserv-aws-ipi-arm-f28	N/A	periodic	Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.21-netobserv-metal-ds-ipi-ovn-ipv4-f28-virt	N/A	periodic	Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.20-netobserv-metal-ds-ipi-ovn-dualstack-primaryv6-f28-ipv6	N/A	periodic	Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.18-netobserv-aws-ipi-arm-f28	N/A	periodic	Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-5.0-netobserv-aws-ipi-amd-f7	N/A	periodic	Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.19-netobserv-metal-ds-ipi-ovn-ipv4-f28-virt	N/A	periodic	Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.21-netobserv-gcp-ipi-amd-f14	N/A	periodic	Registry content changed

A total of 49 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[jpinsonneau]

/pj-rehearse pull-ci-netobserv-netobserv-web-console-main-integration-tests

[openshift-merge-bot]

@jpinsonneau: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

[jpinsonneau]

/pj-rehearse pull-ci-netobserv-netobserv-web-console-main-integration-tests

[openshift-merge-bot]

@jpinsonneau: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@jpinsonneau: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/netobserv/netobserv-web-console/main/integration-tests	727bec6	link	unknown	/pj-rehearse pull-ci-netobserv-netobserv-web-console-main-integration-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.