PowerVC: Add checks script - #83197
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (8)
🚧 Files skipped from review as they are similar to previous changes (7)
WalkthroughThe change adds a scheduled multiarch CI workflow for PowerVC. The workflow validates its environment, installs architecture-specific tools, and checks RHCOS images across supported OpenShift and RHEL versions. ChangesPowerVC checks CI integration
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant NightlySchedule
participant Workflow
participant CIStep
participant ChecksScript
participant PowerVC
NightlySchedule->>Workflow: Start scheduled PowerVC checks
Workflow->>CIStep: Invoke openshift-powervc-checks
CIStep->>ChecksScript: Run with CLOUD and credentials
ChecksScript->>PowerVC: Query RHCOS image streams
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-merge-bot
Bot
added
the
rehearsals-ack
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-5.0.yaml`:
- Around line 677-685: Run make update after adding the ocp-powervc-checks
periodic job, then commit all generated zz_generated_metadata and Prow job
configuration changes so the nightly workflow is scheduled.
In
`@ci-operator/step-registry/openshift/powervc/checks/openshift-powervc-checks-commands.sh`:
- Around line 102-111: After setting HOME in the OpenShift PowerVC checks
script, configure the mounted credentials by copying and validating clouds.yaml
and ocp-ci-ca.pem from /var/run/powervc-ipi-cicd-secrets/powervc-creds into the
corresponding ${HOME}/.config/openstack locations. Reuse the setup and
validation behavior from ipi-conf-powervc-commands.sh before the helper runs,
ensuring failures exit through the existing error handling.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 71070626-8756-4a20-ac80-4e3810f9324c
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/multiarch/openshift-multiarch-main-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (7)
ci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-5.0.yamlci-operator/step-registry/openshift/powervc/checks/OWNERSci-operator/step-registry/openshift/powervc/checks/openshift-powervc-checks-commands.shci-operator/step-registry/openshift/powervc/checks/openshift-powervc-checks-ref.metadata.jsonci-operator/step-registry/openshift/powervc/checks/openshift-powervc-checks-ref.yamlci-operator/step-registry/openshift/powervc/checks/openshift-powervc-checks-workflow.metadata.jsonci-operator/step-registry/openshift/powervc/checks/openshift-powervc-checks-workflow.yaml
2b91427 to
51cceaa
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
/pj-rehearse network-access-allowed |
|
@deepsm007: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-multiarch-main-nightly-5.0-ocp-powervc-checks |
|
@hamzy: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@hamzy: job(s): periodic-ci-openshift-multiarch-main-nightly-5.0-ocp-powervc-checks either don't exist or were not found to be affected, and cannot be rehearsed |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepsm007, hamzy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/pj-rehearse periodic-ci-openshift-multiarch-main-nightly-5.0-ocp-powervc-checks |
|
@hamzy: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
51cceaa to
58ae35d
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/step-registry/openshift/powervc/checks/openshift-powervc-checks-commands.sh`:
- Around line 181-190: Update the required-tools list in the tool verification
block to use the installed executable name `ocp-ipi-powervc` instead of
`PowerVC-Tool`, while retaining the existing `openstack` check and availability
logging.
- Around line 156-176: Define and initialize SECRETS_DIR to the mounted
credential directory before the file-existence checks in the openshift-powervc
checks flow. Ensure this assignment occurs before any ${SECRETS_DIR} expansion
so clouds.yaml and ocp-ci-ca.pem can be validated and copied successfully.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 22541ba1-12e7-4f86-ae10-116836661951
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/multiarch/openshift-multiarch-main-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (8)
ci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-5.0.yamlci-operator/step-registry/openshift/powervc/OWNERSci-operator/step-registry/openshift/powervc/checks/OWNERSci-operator/step-registry/openshift/powervc/checks/openshift-powervc-checks-commands.shci-operator/step-registry/openshift/powervc/checks/openshift-powervc-checks-ref.metadata.jsonci-operator/step-registry/openshift/powervc/checks/openshift-powervc-checks-ref.yamlci-operator/step-registry/openshift/powervc/checks/openshift-powervc-checks-workflow.metadata.jsonci-operator/step-registry/openshift/powervc/checks/openshift-powervc-checks-workflow.yaml
🚧 Files skipped from review as they are similar to previous changes (7)
- ci-operator/step-registry/openshift/powervc/OWNERS
- ci-operator/step-registry/openshift/powervc/checks/openshift-powervc-checks-workflow.yaml
- ci-operator/step-registry/openshift/powervc/checks/OWNERS
- ci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-5.0.yaml
- ci-operator/step-registry/openshift/powervc/checks/openshift-powervc-checks-ref.metadata.json
- ci-operator/step-registry/openshift/powervc/checks/openshift-powervc-checks-workflow.metadata.json
- ci-operator/step-registry/openshift/powervc/checks/openshift-powervc-checks-ref.yaml
58ae35d to
123986e
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/step-registry/openshift/powervc/checks/openshift-powervc-checks-commands.sh`:
- Around line 102-103: Replace the global HOME assignment in the PowerVC setup
with a uniquely created private temporary directory, and use it for PowerVC
credential files. In the related setup block around the copied files, ensure
each copied credential file is installed with mode 0600, preserving the existing
file names and command flow.
- Around line 128-146: Update the tool-download flow around the tools array and
curl loop to validate both ocp-ipi-powervc-linux-${machine} and
print-stream-json.sh against trusted checksums or signatures before chmod or
execution. Obtain the expected validation metadata from a trusted source, fail
closed with log_error and exit 1 on missing or mismatched validation, and only
make assets executable after both validations succeed.
- Around line 142-145: Update the curl invocation in the download loop to add
bounded retry, connection-timeout, and total max-time options while preserving
the existing failure handling and output behavior. Use the existing source_name
and tool_url flow in the surrounding download command.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 14f16dd0-c843-49d1-bb5b-baf76ca5e283
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/multiarch/openshift-multiarch-main-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (8)
ci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-5.0.yamlci-operator/step-registry/openshift/powervc/OWNERSci-operator/step-registry/openshift/powervc/checks/OWNERSci-operator/step-registry/openshift/powervc/checks/openshift-powervc-checks-commands.shci-operator/step-registry/openshift/powervc/checks/openshift-powervc-checks-ref.metadata.jsonci-operator/step-registry/openshift/powervc/checks/openshift-powervc-checks-ref.yamlci-operator/step-registry/openshift/powervc/checks/openshift-powervc-checks-workflow.metadata.jsonci-operator/step-registry/openshift/powervc/checks/openshift-powervc-checks-workflow.yaml
🚧 Files skipped from review as they are similar to previous changes (7)
- ci-operator/step-registry/openshift/powervc/checks/OWNERS
- ci-operator/step-registry/openshift/powervc/checks/openshift-powervc-checks-workflow.yaml
- ci-operator/step-registry/openshift/powervc/checks/openshift-powervc-checks-ref.yaml
- ci-operator/step-registry/openshift/powervc/checks/openshift-powervc-checks-workflow.metadata.json
- ci-operator/step-registry/openshift/powervc/OWNERS
- ci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-5.0.yaml
- ci-operator/step-registry/openshift/powervc/checks/openshift-powervc-checks-ref.metadata.json
|
/pj-rehearse periodic-ci-openshift-multiarch-main-nightly-5.0-ocp-powervc-checks |
|
@hamzy: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@hamzy: job(s): periodic-ci-openshift-multiarch-main-nightly-5.0-ocp-powervc-checks either don't exist or were not found to be affected, and cannot be rehearsed |
Add a nightly script for PowerVC which perform enviromental checks.
123986e to
743fdfb
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files (
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse network-access-allowed |
|
@deepsm007: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-multiarch-main-nightly-5.0-ocp-powervc-checks |
|
@hamzy: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/retest prow-config |
|
/test prow-config |
|
@hamzy: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Add a nightly script for PowerVC which perform enviromental checks.
Summary by CodeRabbit
Adds a nightly OpenShift CI workflow for PowerVC environmental checks. The workflow runs on the
powervc-1cluster at0 12 * * *with intranet, DNS, and unrestricted network access.The checks validate the environment, install architecture-specific tools, configure PowerVC access, and verify RHCOS images across supported OpenShift and RHEL versions. The workflow mounts PowerVC credentials and defines resource settings with a 60-minute grace period. Ownership metadata assigns PowerVC and multi-architecture maintainers.