Add Prow & Unit Testing to DRA Driver SR-IOV - #83206
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThe pull request onboards ChangesRepository onboarding
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@core-services/prow/02_config/openshift/dra-driver-sriov/_prowconfig.yaml`:
- Around line 3-5: Update Tide’s query labels list in the Prow configuration to
include the verified label alongside approved and lgtm, ensuring only verified
pull requests satisfy the merge query.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 64b3279f-179f-4e4e-b470-9cd03b8d1c13
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/dra-driver-sriov/openshift-dra-driver-sriov-main-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (3)
ci-operator/config/openshift/dra-driver-sriov/openshift-dra-driver-sriov-main.yamlcore-services/prow/02_config/openshift/dra-driver-sriov/_pluginconfig.yamlcore-services/prow/02_config/openshift/dra-driver-sriov/_prowconfig.yaml
7dedb32 to
33d2c9e
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
33d2c9e to
821f5a9
Compare
|
/pj-rehearse |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
/pj-rehearse |
|
@wizhaoredhat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
821f5a9 to
0274645
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
0274645 to
146bdf0
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Signed-off-by: William Zhao <wizhao@redhat.com>
146bdf0 to
0c6f9a8
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wizhaoredhat The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse |
|
@wizhaoredhat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@wizhaoredhat: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary by CodeRabbit
openshift/dra-driver-sriovrepository.Dockerfile.ocpand integrates releases.make testunit test job with resource settings.approved,lgtm, andverifiedlabels that have no blocking labels.