Disable all 5.1 aws-perfscale cron jobs - #83210
Conversation
Remove cron schedules and set always_run: false for 7 aws-perfscale profile jobs: control-plane-120nodes, control-plane-252nodes, data-path-9nodes, control-plane-ipsec-120nodes, control-plane-ipsec-252nodes in 5.1 nightly, and loaded-upgrade-120nodes, loaded-upgrade-252nodes in 5.1 loaded-upgrade. All aws-perfscale-qe profile jobs remain unchanged. Assisted-by: Claude Signed-off-by: Mohit Sheth <msheth@redhat.com>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (2)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThe PerfScale AWS nightly x86 configurations remove cron schedules from seven tests and set ChangesPerfScale schedule controls
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift-eng/ocp-perfscale/openshift-eng-ocp-perfscale-main__aws-5.1-nightly-x86.yaml`:
- Around line 78-79: Regenerate the Prow periodic jobs using make update or the
applicable split generation targets so stale generated jobs for source tests
without cron schedules are removed. Apply this to the anchor sites at
ci-operator/config/openshift-eng/ocp-perfscale/openshift-eng-ocp-perfscale-main__aws-5.1-nightly-x86.yaml:78-79,
:114-115, :332-333, :385-386, and :423-424, and the sibling sites at
ci-operator/config/openshift-eng/ocp-perfscale/openshift-eng-ocp-perfscale-main__aws-5.1-nightly-x86-loaded-upgrade-from-4.22.yaml:50-51
and :110-111; remove the corresponding stale periodic jobs rather than manually
changing their schedules.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: c67feaa3-9fa2-481a-9a67-dc1671e0ee97
📒 Files selected for processing (2)
ci-operator/config/openshift-eng/ocp-perfscale/openshift-eng-ocp-perfscale-main__aws-5.1-nightly-x86-loaded-upgrade-from-4.22.yamlci-operator/config/openshift-eng/ocp-perfscale/openshift-eng-ocp-perfscale-main__aws-5.1-nightly-x86.yaml
Assisted-by: Claude Signed-off-by: Mohit Sheth <msheth@redhat.com>
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@mohit-sheth: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afcollins, mohit-sheth The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/pj-rehearse ack |
|
@mohit-sheth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Summary
always_run: falsefor 7 aws-perfscale profile jobs in 5.1:control-plane-120nodes,control-plane-252nodes,data-path-9nodes,control-plane-ipsec-120nodes,control-plane-ipsec-252nodesin 5.1 nightlyloaded-upgrade-120nodes,loaded-upgrade-252nodesin 5.1 loaded-upgradeSummary by CodeRabbit
aws-perfscalecron jobs in OpenShift CI.always_run: false.aws-perfscale-qeprofile jobs unchanged.