Skip to content

Disable all 5.1 aws-perfscale cron jobs - #83210

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
mohit-sheth:disable-5.1-aws-perfscale-crons
Aug 10, 2026
Merged

Disable all 5.1 aws-perfscale cron jobs#83210
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
mohit-sheth:disable-5.1-aws-perfscale-crons

Conversation

@mohit-sheth

@mohit-sheth mohit-sheth commented Aug 10, 2026

Copy link
Copy Markdown
Member

Summary

  • Remove cron schedules and set always_run: false for 7 aws-perfscale profile jobs in 5.1:
    • control-plane-120nodes, control-plane-252nodes, data-path-9nodes, control-plane-ipsec-120nodes, control-plane-ipsec-252nodes in 5.1 nightly
    • loaded-upgrade-120nodes, loaded-upgrade-252nodes in 5.1 loaded-upgrade
  • All aws-perfscale-qe profile jobs (cudn, udn, fips, netpol, etc.) remain unchanged

Summary by CodeRabbit

  • Disabled all seven 5.1 aws-perfscale cron jobs in OpenShift CI.
  • Disabled five nightly jobs and two loaded-upgrade jobs by removing their cron schedules and setting always_run: false.
  • Kept the aws-perfscale-qe profile jobs unchanged.

Remove cron schedules and set always_run: false for 7 aws-perfscale
profile jobs: control-plane-120nodes, control-plane-252nodes,
data-path-9nodes, control-plane-ipsec-120nodes,
control-plane-ipsec-252nodes in 5.1 nightly, and loaded-upgrade-120nodes,
loaded-upgrade-252nodes in 5.1 loaded-upgrade. All aws-perfscale-qe
profile jobs remain unchanged.

Assisted-by: Claude
Signed-off-by: Mohit Sheth <msheth@redhat.com>
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/openshift-eng/ocp-perfscale/openshift-eng-ocp-perfscale-main-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-eng/ocp-perfscale/openshift-eng-ocp-perfscale-main-presubmits.yaml is excluded by !ci-operator/jobs/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: fba663bc-0e5b-4a8d-98f2-3b8651efa233

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

The PerfScale AWS nightly x86 configurations remove cron schedules from seven tests and set always_run: false for each test.

Changes

PerfScale schedule controls

Layer / File(s) Summary
Disable scheduled PerfScale jobs
ci-operator/config/openshift-eng/ocp-perfscale/*.yaml
Seven control-plane, data-path, IPsec, and loaded-upgrade tests no longer define cron schedules and explicitly set always_run: false.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Suggested reviewers: deepsm007, redhat-chai-bot

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: disabling all seven 5.1 aws-perfscale cron jobs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The patch changes only two YAML CI configurations, removing cron fields and adding static always_run/as entries; it introduces no Ginkgo test titles or dynamic title values.
Test Structure And Quality ✅ Passed The PR changes only two YAML CI configuration files; no Ginkgo test code, It blocks, or cluster operations are changed, so this check is not applicable.
Microshift Test Compatibility ✅ Passed The pull request changes only two CI YAML files and adds no Ginkgo e2e tests, so MicroShift compatibility checks do not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The commit changes only two CI YAML files to disable seven cron jobs; it adds no Ginkgo tests or Go files requiring SNO compatibility review.
Topology-Aware Scheduling Compatibility ✅ Passed The changed files are CI test configurations. They only remove cron fields and set always_run: false; no deployment, operator, controller, or topology scheduling constraints are introduced.
Ote Binary Stdout Contract ✅ Passed The PR changes only two YAML schedules; all added lines are job names or always_run: false, with no OTE code or process-level stdout writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR changes only two YAML configuration files, removing cron fields and adding always_run: false; it adds no Ginkgo e2e tests or networking code.
No-Weak-Crypto ✅ Passed The parent diff contains only two YAML config changes; added lines set job names and always_run:false, with no weak algorithms, crypto code, or secret comparisons.
Container-Privileges ✅ Passed The two changed YAML files only remove cron entries and add always_run: false; scans found no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The patch only changes cron and always_run fields; it adds no logging or sensitive-data output. Existing log-link reporter templates remain unchanged.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from jmguzik and smg247 August 10, 2026 21:03
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@ci-operator/config/openshift-eng/ocp-perfscale/openshift-eng-ocp-perfscale-main__aws-5.1-nightly-x86.yaml`:
- Around line 78-79: Regenerate the Prow periodic jobs using make update or the
applicable split generation targets so stale generated jobs for source tests
without cron schedules are removed. Apply this to the anchor sites at
ci-operator/config/openshift-eng/ocp-perfscale/openshift-eng-ocp-perfscale-main__aws-5.1-nightly-x86.yaml:78-79,
:114-115, :332-333, :385-386, and :423-424, and the sibling sites at
ci-operator/config/openshift-eng/ocp-perfscale/openshift-eng-ocp-perfscale-main__aws-5.1-nightly-x86-loaded-upgrade-from-4.22.yaml:50-51
and :110-111; remove the corresponding stale periodic jobs rather than manually
changing their schedules.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: c67feaa3-9fa2-481a-9a67-dc1671e0ee97

📥 Commits

Reviewing files that changed from the base of the PR and between e4677b0 and ed667c1.

📒 Files selected for processing (2)
  • ci-operator/config/openshift-eng/ocp-perfscale/openshift-eng-ocp-perfscale-main__aws-5.1-nightly-x86-loaded-upgrade-from-4.22.yaml
  • ci-operator/config/openshift-eng/ocp-perfscale/openshift-eng-ocp-perfscale-main__aws-5.1-nightly-x86.yaml

Assisted-by: Claude
Signed-off-by: Mohit Sheth <msheth@redhat.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@mohit-sheth: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-eng-ocp-perfscale-main-aws-5.1-nightly-x86-control-plane-120nodes openshift-eng/ocp-perfscale presubmit Presubmit changed
pull-ci-openshift-eng-ocp-perfscale-main-aws-5.1-nightly-x86-control-plane-252nodes openshift-eng/ocp-perfscale presubmit Presubmit changed
pull-ci-openshift-eng-ocp-perfscale-main-aws-5.1-nightly-x86-control-plane-ipsec-120nodes openshift-eng/ocp-perfscale presubmit Presubmit changed
pull-ci-openshift-eng-ocp-perfscale-main-aws-5.1-nightly-x86-control-plane-ipsec-252nodes openshift-eng/ocp-perfscale presubmit Presubmit changed
pull-ci-openshift-eng-ocp-perfscale-main-aws-5.1-nightly-x86-data-path-9nodes openshift-eng/ocp-perfscale presubmit Presubmit changed
pull-ci-openshift-eng-ocp-perfscale-main-aws-5.1-nightly-x86-loaded-upgrade-from-4.22-loaded-upgrade-120nodes openshift-eng/ocp-perfscale presubmit Presubmit changed
pull-ci-openshift-eng-ocp-perfscale-main-aws-5.1-nightly-x86-loaded-upgrade-from-4.22-loaded-upgrade-252nodes openshift-eng/ocp-perfscale presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

@mohit-sheth: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@afcollins afcollins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2026
@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afcollins, mohit-sheth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mohit-sheth

Copy link
Copy Markdown
Member Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@mohit-sheth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 10, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 57b148b into openshift:main Aug 10, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants