Test OS_IMAGE_STREAM: rhel-9 for fips-24nodes perf job by mcornea · Pull Request #83258 · openshift/release

mcornea · 2026-08-11T13:03:50Z

Summary by CodeRabbit

Configures the control-plane-fips-24nodes OpenShift performance job to use the rhel-9 OS_IMAGE_STREAM.
This updates the AWS 5.0 nightly x86 CI configuration for OpenShift performance testing.

openshift-ci · 2026-08-11T13:04:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mcornea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

coderabbitai · 2026-08-11T13:04:30Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 81cecacb-6918-46db-9d07-dbbdf5e3b4cd

📥 Commits

Reviewing files that changed from the base of the PR and between 5fe0732 and cab31d3.

📒 Files selected for processing (1)

ci-operator/config/openshift-eng/ocp-perfscale/openshift-eng-ocp-perfscale-main__aws-5.0-nightly-x86.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

ci-operator/config/openshift-eng/ocp-perfscale/openshift-eng-ocp-perfscale-main__aws-5.0-nightly-x86.yaml

Walkthrough

The control-plane-fips-24nodes job now sets OS_IMAGE_STREAM to rhel-9.

Changes

FIPS image stream configuration

Layer / File(s)	Summary
Set the FIPS job image stream `ci-operator/config/openshift-eng/ocp-perfscale/openshift-eng-ocp-perfscale-main__aws-5.0-nightly-x86.yaml`	The `control-plane-fips-24nodes` job defines `OS_IMAGE_STREAM` as `rhel-9`.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: danilo-gemoli, deepsm007

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes testing OS_IMAGE_STREAM=rhel-9 for the fips-24nodes performance job, which matches the main change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR adds only static OS_IMAGE_STREAM: rhel-9 to a YAML job; it changes no Ginkgo It, Describe, Context, or When titles or test-source files.
Test Structure And Quality	✅ Passed	The change adds one YAML environment variable only; it does not modify Ginkgo tests, so the listed test-quality requirements are not applicable.
Microshift Test Compatibility	✅ Passed	The PR changes only one perf-scale YAML environment variable; it adds no Ginkgo e2e tests or MicroShift-incompatible API usage.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR changes only a CI YAML environment variable; it adds no Ginkgo e2e tests or multi-node test assumptions requiring SNO review.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR adds only OS_IMAGE_STREAM: rhel-9 to a CI job; it modifies no deployment, operator, controller, or scheduling constraint.
Ote Binary Stdout Contract	✅ Passed	The patch changes only one YAML env entry; it adds OS_IMAGE_STREAM: rhel-9 and contains no OTE binary, suite setup, or process-level stdout write.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR changes only OS_IMAGE_STREAM in an existing YAML job; it adds no Ginkgo tests and no IPv4 or external connectivity logic.
No-Weak-Crypto	✅ Passed	The commit changes only one YAML value, adding OS_IMAGE_STREAM: rhel-9; it adds no weak-crypto usage, custom crypto, or secret comparison.
Container-Privileges	✅ Passed	The PR adds only OS_IMAGE_STREAM: rhel-9. The changed job and its referenced step/workflow YAML contain no privileged, host namespace, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	The only added line sets OS_IMAGE_STREAM to the non-sensitive value rhel-9; its consumer logs only that value and introduces no password, token, API key, PII, or customer data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

openshift-merge-bot · 2026-08-11T13:09:33Z

[REHEARSALNOTIFIER]
@mcornea: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-eng-ocp-perfscale-main-aws-5.0-nightly-x86-control-plane-fips-24nodes	N/A	periodic	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Signed-off-by: Marius Cornea <mcornea@redhat.com>

coderabbitai · 2026-08-11T13:16:32Z

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

openshift-merge-bot · 2026-08-11T13:21:24Z

@mcornea: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

mcornea · 2026-08-11T13:31:17Z