Skip to content

Test - do not merge - #83271

Open
asergienk wants to merge 1 commit into
openshift:mainfrom
asergienk:test_pjrehearse
Open

Test - do not merge#83271
asergienk wants to merge 1 commit into
openshift:mainfrom
asergienk:test_pjrehearse

Conversation

@asergienk

@asergienk asergienk commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Test - do not merge

Summary by CodeRabbit

  • Updates the optional-operator subscription CI step to add a trailing space to the CatalogSource readiness success log after the reported wait duration.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 0877e89d-34fb-41fd-b90d-afe9abc5e9c5

📥 Commits

Reviewing files that changed from the base of the PR and between 73a24d9 and bf5edb9.

📒 Files selected for processing (1)
  • ci-operator/step-registry/optional-operators/subscribe/optional-operators-subscribe-commands.sh

Walkthrough

The CatalogSource readiness success log now includes a trailing space after the reported wait duration.

Changes

CatalogSource logging

Layer / File(s) Summary
Update success log format
ci-operator/step-registry/optional-operators/subscribe/optional-operators-subscribe-commands.sh
The success message adds a trailing space after the elapsed-seconds value.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title identifies the pull request as a test, but it does not describe the CatalogSource readiness log change. Use a concise title that describes the log message change, such as "Add trailing space to CatalogSource readiness log".
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only a shell log message; no test files or Ginkgo title APIs were added or modified, so no unstable test names are present.
Test Structure And Quality ✅ Passed The commit changes one shell-script log line only; it adds no Ginkgo tests, cluster operations in test code, or test assertions to review.
Microshift Test Compatibility ✅ Passed The pull request changes only a shell log message. It adds no Ginkgo e2e test, so the MicroShift API compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull request changes one shell log message and adds no Ginkgo e2e tests or node-topology assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The only change adds a trailing space to a CatalogSource readiness log message; it adds no manifests, replicas, affinities, selectors, tolerations, topology constraints, or PDBs.
Ote Binary Stdout Contract ✅ Passed The commit changes only a shell step-registry log message; it adds no OTE binary entry point or process-level stdout code.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR changes only a shell log message; the diff adds no Ginkgo e2e test, IPv4 assumption, or external connectivity requirement.
No-Weak-Crypto ✅ Passed The patch only adds a trailing space to a CatalogSource readiness log; it adds no weak crypto, custom crypto, or secret comparison.
Container-Privileges ✅ Passed The PR changes only a CatalogSource readiness log string by adding a trailing space. It adds no privileged setting, host namespace, SYS_ADMIN capability, root user, or allowPrivilegeEscalation field.
No-Sensitive-Data-In-Logs ✅ Passed The only PR change adds a trailing space to a readiness log; it logs a timestamp and numeric wait duration, with no sensitive data.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asergienk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@asergienk: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

@asergienk

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-redhat-openshift-ecosystem-cvp-ocp-4.22-cvp-common-claim

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@asergienk: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

@asergienk

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-redhat-openshift-ecosystem-cvp-ocp-4.22-cvp-common-claim

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@asergienk: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@asergienk

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-redhat-openshift-ecosystem-cvp-ocp-4.20-cvp-fips-common-claim

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@asergienk: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

@asergienk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-redhat-openshift-ecosystem-cvp-ocp-4.22-cvp-common-claim bf5edb9 link unknown /pj-rehearse periodic-ci-redhat-openshift-ecosystem-cvp-ocp-4.22-cvp-common-claim

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant