Skip to content

NO-JIRA: e2e only in main-alerts branch - #83409

Merged
openshift-merge-bot[bot] merged 3 commits into
openshift:mainfrom
etmurasaki:etmura-manag-api
Aug 14, 2026
Merged

NO-JIRA: e2e only in main-alerts branch#83409
openshift-merge-bot[bot] merged 3 commits into
openshift:mainfrom
etmurasaki:etmura-manag-api

Conversation

@etmurasaki

@etmurasaki etmurasaki commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

The e2e-management-api CI test for openshift-monitoring-plugin now runs on the main branch. The configuration no longer skips this test on main.

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@etmurasaki: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 13, 2026
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 2b5d410d-40b2-4202-aff2-574b2693ba11

📥 Commits

Reviewing files that changed from the base of the PR and between a503bb9 and 224140e.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/monitoring-plugin/openshift-monitoring-plugin-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/monitoring-plugin/openshift-monitoring-plugin-main.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/openshift/monitoring-plugin/openshift-monitoring-plugin-main.yaml

Walkthrough

The monitoring plugin CI configuration removes the rule that skipped the e2e-management-api job on the main branch.

Changes

Monitoring plugin CI

Layer / File(s) Summary
Enable main branch test execution
ci-operator/config/openshift/monitoring-plugin/openshift-monitoring-plugin-main.yaml
Removes the skip_branches: ^main$ rule from the e2e-management-api job.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Mergeability Score: ⚪ Minimal · up to 22414

This PR makes a small, localized CI configuration change, and no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: jgbernalp, peteryurkovich

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title identifies the e2e branch-selection change, although it does not clearly state that the job now runs on main.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only CI configuration and generated job YAML; no Ginkgo test title constructs or dynamic test names were added or changed.
Test Structure And Quality ✅ Passed The pull request changes only CI configuration YAML files; it adds no Ginkgo test code, It blocks, fixtures, waits, or assertions for this check to assess.
Microshift Test Compatibility ✅ Passed The commit changes only Prow CI YAML; it adds no Ginkgo tests or API/resource references, so the MicroShift compatibility check is not triggered.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The commit changes only two CI YAML files and adds no Go/Ginkgo test declarations; the SNO compatibility check is therefore not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The diff changes only CI test configuration and generated presubmit metadata (optional, branch lists, and triggers); it adds no workload scheduling constraints, deployment, operator, or controlle...
Ote Binary Stdout Contract ✅ Passed The relevant PR change is CI YAML only (optional: true and branch selection); it adds no OTE binary or process-level stdout/logging code.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR changes only CI YAML and generated Prow job settings; no Ginkgo test or network code was added or modified, so this check has no applicable failure condition.
No-Weak-Crypto ✅ Passed The parent-to-HEAD diff changes CI job scheduling only; it adds optional/skip_branches settings and introduces no weak crypto or secret-comparison code.
Container-Privileges ✅ Passed The PR diff only changes optional/skip_branches and the generated trigger; it introduces no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The diff adds only optional and trigger YAML fields; it adds no logging statements or sensitive values. Existing log links and secret mounts are unchanged.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@etmurasaki: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-monitoring-plugin-main-e2e-management-api openshift/monitoring-plugin presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@PeterYurkovich

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2026
@openshift-ci

openshift-ci Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: etmurasaki, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@etmurasaki

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@etmurasaki: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 14, 2026
@openshift-ci

openshift-ci Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

@etmurasaki: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 6ab110e into openshift:main Aug 14, 2026
16 checks passed
@etmurasaki
etmurasaki deleted the etmura-manag-api branch August 14, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants