TRACING-6644 | Sse 4.22 for OTEL FIPS test with PQC ML-KEM - #83623
Conversation
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe OpenShift 4.22 FIPS stage configuration updates images and release metadata. It updates logging channels, enables PQC checks, configures the scan namespace, changes skipped tests, and adds the TLS scanner test step. The GCP IPI workflow remains unchanged. ChangesOpenTelemetry Operator 4.22 stage configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: 🔵 Low · up to The PR updates FIPS CI jobs and test configuration; merge readiness depends on confirming the intended scan namespace and regenerating/validating generated CI metadata. These are bounded, non-blocking follow-ups, so the change is mergeable with owner awareness. Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
IshwarKanse
left a comment
There was a problem hiding this comment.
Hi @pavolloffay, thanks for updating the OTEL FIPS stage config to 4.22 with PQC ML-KEM support. A few issues to address:
1. Cluster logging and Loki operator channels should be stable-6.6
The PR currently sets both loki-operator and cluster-logging channels to stable-6.4. These should be updated to stable-6.6:
{"name": "loki-operator", "source": "redhat-operators", "channel": "stable-6.6", ...}
{"name": "cluster-logging", "source": "redhat-operators", "channel": "stable-6.6", ...}2. tls-scanner-run ref should come before distributed-tracing-tests-opentelemetry-stage
The TLS scanner should run before the OpenTelemetry stage tests. Current order:
- ref: distributed-tracing-tests-opentelemetry-stage
- ref: tls-scanner-runShould be:
- ref: tls-scanner-run
- ref: distributed-tracing-tests-opentelemetry-stage3. Missing entries in SKIP_TESTS
Two test skip entries were removed but still need to be skipped:
tests/e2e-otel/oidcauthextension— not compatible with FIPStests/e2e/smoke-ports— requires permissions disabled on FIPS cluster
Only tests/e2e-openshift/export-to-cluster-logging-lokistack can be safely removed from the skip list.
The SKIP_TESTS should be:
SKIP_TESTS: tests/e2e/smoke-ip-families tests/e2e-otel/*aws* tests/e2e-otel/oidcauthextension
tests/e2e-otel/google* tests/e2e/smoke-ports tests/e2e-instrumentation/instrumentation-go
4. make update needs to be run
The CI checks ci-operator-config-metadata and generated-config are both failing because the generated Prow job configs haven't been regenerated after renaming the file from 4.17 to 4.22. Please run make update locally and commit the generated files.
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@pavolloffay: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IshwarKanse, pavolloffay The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@IshwarKanse: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
https://redhat.atlassian.net/browse/TRACING-6644
Summary by CodeRabbit
stable-6.6.