Skip to content

alerting: make github token alert less sensitive#8534

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
stevekuznetsov:skuznets/less-sensitive-alert
Apr 23, 2020
Merged

alerting: make github token alert less sensitive#8534
openshift-merge-robot merged 1 commit into
openshift:masterfrom
stevekuznetsov:skuznets/less-sensitive-alert

Conversation

@stevekuznetsov
Copy link
Copy Markdown
Contributor

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

/assign @alvaroaleman

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [alvaroaleman,stevekuznetsov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4e36c73 into openshift:master Apr 23, 2020
bryan-cox added a commit to bryan-cox/release that referenced this pull request May 21, 2026
The pipeline controller's lgtm-config only watched the main branch
for openshift/hypershift. This meant e2e jobs using
pipeline_skip_if_only_changed on release-4.22 never triggered because
the controller didn't monitor that branch.

Multiple release-4.22 PRs merged without e2e test coverage (openshift#8564,
openshift#8534, openshift#8447) while the same commits on main got full e2e runs.

Remove the branch filter entirely so all branches are watched,
matching the pattern used by other repos in the config. This prevents
the same issue on future release branches.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
openshift-merge-bot Bot pushed a commit that referenced this pull request May 21, 2026
The pipeline controller's lgtm-config only watched the main branch
for openshift/hypershift. This meant e2e jobs using
pipeline_skip_if_only_changed on release-4.22 never triggered because
the controller didn't monitor that branch.

Multiple release-4.22 PRs merged without e2e test coverage (#8564,
#8534, #8447) while the same commits on main got full e2e runs.

Remove the branch filter entirely so all branches are watched,
matching the pattern used by other repos in the config. This prevents
the same issue on future release branches.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants