Skip to content

Metrics to collect the usage of multus cni plugin for sriov and all n… - #262

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
aneeshkp:multus-telemeter
Nov 6, 2019
Merged

Metrics to collect the usage of multus cni plugin for sriov and all n…#262
openshift-merge-robot merged 1 commit into
openshift:masterfrom
aneeshkp:multus-telemeter

Conversation

@aneeshkp

@aneeshkp aneeshkp commented Nov 1, 2019

Copy link
Copy Markdown
Contributor

…etwork types
This PR is for collecting usage of multus CNI plugin labeled by networks.
These are the related PR's to expose metrics to Prometheus from the instance
openshift/cluster-network-operator#377
(Yet to be merged)

Note: closed old PR and opened this

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 1, 2019
@aneeshkp

aneeshkp commented Nov 1, 2019

Copy link
Copy Markdown
Contributor Author

@brancz
Made changes as you suggested . I had to close old PR
all_instances
record_rules_forinstance_up

@aneeshkp

aneeshkp commented Nov 1, 2019

Copy link
Copy Markdown
Contributor Author

/assign @squat

@s-urbaniak

Copy link
Copy Markdown
Contributor

/hold

let's hold this until openshift/cluster-network-operator#377 is merged.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2019
@s-urbaniak

Copy link
Copy Markdown
Contributor

/approve
i believe all the comments have been addressed, but leaving a 3rd and 4th eye to @brancz / @squat

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2019
@brancz

brancz commented Nov 4, 2019

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2019
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp, brancz, s-urbaniak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aneeshkp

aneeshkp commented Nov 5, 2019

Copy link
Copy Markdown
Contributor Author

@s-urbaniak openshift/cluster-network-operator#377 is successfully merged. Can this be merged?

@s-urbaniak

Copy link
Copy Markdown
Contributor

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2019
@s-urbaniak

Copy link
Copy Markdown
Contributor

@aneeshkp looks good 👍 please follow https://url.corp.redhat.com/730aaa1 to add a subsequent PR against cluster monitoring operator.

@openshift-merge-robot
openshift-merge-robot merged commit 222b332 into openshift:master Nov 6, 2019
@aneeshkp

aneeshkp commented Nov 6, 2019

Copy link
Copy Markdown
Contributor Author

@s-urbaniak Thanks, I will follow the next step for PR against cluster monitoring operator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants