Skip to content

ci: gate changelog check to upstream repo on oadp-1.6 - #568

Closed
Joeavaikath wants to merge 3 commits into
oadp-1.6from
fix/gate-changelog-check-oadp-1.6
Closed

ci: gate changelog check to upstream repo on oadp-1.6#568
Joeavaikath wants to merge 3 commits into
oadp-1.6from
fix/gate-changelog-check-oadp-1.6

Conversation

@Joeavaikath

Copy link
Copy Markdown

Summary

  • Adds if: github.repository == 'velero-io/velero' guard to the build job in pr-changelog-check.yml on oadp-1.6
  • oadp-dev already carries this guard; oadp-1.6 was missing it
  • The PR changelog check is an upstream velero-io/velero workflow — it has no meaning for PRs opened against the downstream openshift/velero fork

Test plan

  • Verify the Run Changelog Check job is skipped on PRs targeting oadp-1.6 in openshift/velero
  • Verify no change in behavior for PRs in velero-io/velero

Posted via Claude Code

The pr-changelog-check workflow is an upstream velero-io/velero
workflow. Add the same repository guard that oadp-dev carries so
the job is skipped on openshift/velero PRs targeting oadp-1.6.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci
openshift-ci Bot requested review from kaovilai and sseago September 1, 2026 18:02
@openshift-ci

openshift-ci Bot commented Sep 1, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Joeavaikath

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2026
Joeavaikath and others added 2 commits September 1, 2026 11:14
Add `if: github.repository == 'velero-io/velero'` guards to all
workflows that oadp-dev already gates but oadp-1.6 was missing:
- auto_assign_prs.yml (add-reviews job)
- auto_label_prs.yml (triage job)
- pr-codespell.yml (codespell job)
- prow-action.yml (execute job)
- rebase.yml (rebase job)
- stale-issues.yml (stale job)

These workflows are upstream velero-io/velero concerns and should
not run on openshift/velero PRs.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
The .golangci.yml config uses perfsprint.concat-loop which requires
golangci-lint >= v2.6.0. v2.5.0 rejects the config at schema validation.
Matches the bump already applied in PR #551.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@Joeavaikath

Copy link
Copy Markdown
Author

Changes moved to the rebase PR #551 directly on the oadp-rebasebot branch.

@Joeavaikath Joeavaikath closed this Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant