ci: gate changelog check to upstream repo on oadp-1.6 - #568
Closed
Joeavaikath wants to merge 3 commits into
Closed
Conversation
The pr-changelog-check workflow is an upstream velero-io/velero workflow. Add the same repository guard that oadp-dev carries so the job is skipped on openshift/velero PRs targeting oadp-1.6. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Joeavaikath The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add `if: github.repository == 'velero-io/velero'` guards to all workflows that oadp-dev already gates but oadp-1.6 was missing: - auto_assign_prs.yml (add-reviews job) - auto_label_prs.yml (triage job) - pr-codespell.yml (codespell job) - prow-action.yml (execute job) - rebase.yml (rebase job) - stale-issues.yml (stale job) These workflows are upstream velero-io/velero concerns and should not run on openshift/velero PRs. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
The .golangci.yml config uses perfsprint.concat-loop which requires golangci-lint >= v2.6.0. v2.5.0 rejects the config at schema validation. Matches the bump already applied in PR #551. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Author
|
Changes moved to the rebase PR #551 directly on the oadp-rebasebot branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if: github.repository == 'velero-io/velero'guard to thebuildjob inpr-changelog-check.ymlonoadp-1.6oadp-devalready carries this guard;oadp-1.6was missing itopenshift/veleroforkTest plan
Run Changelog Checkjob is skipped on PRs targetingoadp-1.6inopenshift/velerovelero-io/veleroPosted via Claude Code