Trip Details, Trip Viewer Overlay, and Printable Itinerary. #142
Conversation
…nterpart from OTP-UI.
Codecov Report
@@ Coverage Diff @@
## dev #142 +/- ##
==========================================
+ Coverage 10.13% 10.35% +0.21%
==========================================
Files 132 131 -1
Lines 5861 5739 -122
Branches 1711 1671 -40
==========================================
Hits 594 594
+ Misses 4469 4360 -109
+ Partials 798 785 -13
Continue to review full report at Codecov.
|
…unterpart from OTP-UI. Also change PrintLayout to support customIcons from configuration, and remove unused CSS.
binh-dam-ibigroup
changed the title
|
I am also adding |
| @@ -0,0 +1,25 @@ | |||
| import { connect } from 'react-redux' | |||
| import styled from 'styled-components' | |||
| import TripDetailsBase from '@opentripplanner/trip-details' | |||
There was a problem hiding this comment.
Wondering if there's a better name for this import. UnstyledTripDetails? I'm fine with what you have, but it does seem like there might be a better name out there.
There was a problem hiding this comment.
I'm not super opinionated about this. When I do this I usually do this the other way around a la:
import TripDetails from '@opentripplanner/trip-details'
import styled from 'styled-components'
const StyledTripDetails = styled(TripDetails)`
...There was a problem hiding this comment.
Would be nice to agree on some kind of convention.
landonreed
left a comment
landonreed
left a comment
There was a problem hiding this comment.
@binh-dam-ibigroup, does the config need to change at all?
|
There are no changes to the |
evansiroky
left a comment
evansiroky
left a comment
There was a problem hiding this comment.
Looks good. Would be nice to agree on the variable naming conventions.
landonreed
left a comment
landonreed
left a comment
There was a problem hiding this comment.
@binh-dam-ibigroup, a couple of items on the styling:
- The question mark does feel just slightly too big.
- In the print view, could you scale the ped icon down a little and the bus icon up a little?
|
Unfortunately the size of the question mark icon is hard-coded inside OTP-UI...do we want a ticket for this? Also, the bus and walk icons have these proportions natively in OTP-UI icons, so we would have to either resize the icons in OTP-UI or pollute the code with size adjustments... what do you say? |
|
When opentripplanner/otp-ui#104 and opentripplanner/otp-ui#105 get released, you will see the icon size adjustments in OTP-RR. There are no other code work on the OTP-RR repo for integrating trip-details and printable itinerary. |
|
Thanks for the approval. I need to merge the latest changes from dev, then I'll merge this into dev. |
|
🎉 This PR is included in version 1.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR replaces
TripDetailsin lib/components/narrative,TripViewerOverlayin lib/components/map, andPrintableItineraryinlib/components/narrative/printablewith their counterparts from OTP-ui.Visual changes in
TripDetailsare shown in the screenshot below.Visual changes in
PrintableItineraryare shown in the screenshot below.