OTP-UI Icons

[binh-dam-ibigroup]

This PR removes icons from lib/components/icons and uses those from the OTP-UI icons package instead. The PR also removes unused narrative profile components.

EDITS: Please see the Remarks section below for edits and testing notes.

Remarks

1. [Outdated as of 9219719] Full support of custom icons in OTP-ui is pending Add classic icons otp-ui#119, however the refactor is mostly compatible with the currently released OTP-ui library.
2. [Outdated as of 9219719] In

   otp-react-redux/example.js

   Line 30 in 02fef27

   const MyLegIcon = TriMetLegIcon // For testing, you can use () => <Ferry />

   , there is a MyModeIcon variable passed to various ModeIcon props, however ModeIcon props will take effect pending a change in SettingsSelectorPanel in Add classic icons otp-ui#119.
3. [Outdated as of 6c10ea6] As a result, the default icon for "Take Transit" in OTP-RR is changed, and there are subtle visual changes to the itinerary narratives as shown in the screenshots below.
   (Note that the bus and walk icon sizes are pending OTP release per fix(icons): Adjust relative size of bus and walk icons otp-ui#105 to address this comment) Beware, visual changes taking place! (see screenshots below)

screenshot if using LineItinerary

4. As of 6c10ea6, visual styles for trip form elements (not the map or nav bar) match newplanner.trimet.org, and the old styling is abandoned.

[codecov-io]

Codecov Report

Merging #150 into dev will increase coverage by 0.53%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev     #150      +/-   ##
==========================================
+ Coverage   10.51%   11.04%   +0.53%     
==========================================
  Files         107       91      -16     
  Lines        3796     3612     -184     
  Branches     1023      968      -55     
==========================================
  Hits          399      399              
+ Misses       2954     2800     -154     
+ Partials      443      413      -30     

Impacted Files	Coverage Δ
lib/components/app/default-main-panel.js	0.00% <ø> (ø)
lib/components/app/print-layout.js	0.00% <0.00%> (ø)
...mponents/form/connected-settings-selector-panel.js	0.00% <ø> (ø)
lib/components/form/default-search-form.js	0.00% <0.00%> (ø)
lib/components/form/settings-preview.js	0.00% <ø> (ø)
lib/components/form/styled.js	0.00% <0.00%> (ø)
lib/components/form/tabbed-form-panel.js	0.00% <0.00%> (ø)
lib/components/mobile/main.js	0.00% <0.00%> (ø)
lib/components/mobile/options-screen.js	0.00% <0.00%> (ø)
lib/components/mobile/results-screen.js	0.00% <0.00%> (ø)
... and 11 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20974b3...e0373e8. Read the comment docs.

[evansiroky]

Just noticed that this PR depends on #147. I'm going to unassign myself until that one gets merged into dev.

[binh-dam-ibigroup]

There are some components I deleted an need to bring back... I will reassign you when done.

[evansiroky]

Unassigning myself again until #147 is merged.

[landonreed]

See comments regarding adding a new ModeIcon component to otp-ui (in place of the use of TriMetLegIcon in this repo).

[binh-dam-ibigroup]

@landonreed per a suggestion by @evansiroky, I removed the customIcons support but I realized we might still need some folks to occasionally override the std transit or streetcar icons, for instance without having to define a whole new ModeIcon or LegIcon. Let me think through it.

[binh-dam-ibigroup]

@landonreed and @evansiroky, I have updated the opentripplanner/otp-ui packages and updated the examples for custom icon sets accordingly, so you can review.

[landonreed]

@binh-dam-ibigroup, this looks good. I'll condition my approval on merging #164 into this branch.

[evansiroky]

Great work!

[codecov-commenter]

Codecov Report

Merging #150 into dev will increase coverage by 0.52%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev     #150      +/-   ##
==========================================
+ Coverage   10.51%   11.04%   +0.52%     
==========================================
  Files         107       91      -16     
  Lines        3796     3614     -182     
  Branches     1023      968      -55     
==========================================
  Hits          399      399              
+ Misses       2954     2802     -152     
+ Partials      443      413      -30     

Impacted Files	Coverage Δ
lib/components/app/default-main-panel.js	0.00% <ø> (ø)
lib/components/app/print-layout.js	0.00% <0.00%> (ø)
...mponents/form/connected-settings-selector-panel.js	0.00% <ø> (ø)
lib/components/form/default-search-form.js	0.00% <0.00%> (ø)
lib/components/form/settings-preview.js	0.00% <ø> (ø)
lib/components/form/styled.js	0.00% <0.00%> (ø)
lib/components/form/tabbed-form-panel.js	0.00% <0.00%> (ø)
lib/components/mobile/main.js	0.00% <0.00%> (ø)
lib/components/mobile/options-screen.js	0.00% <0.00%> (ø)
lib/components/mobile/results-screen.js	0.00% <0.00%> (ø)
... and 12 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20974b3...6c10ea6. Read the comment docs.

[landonreed]

LGTM, thanks @binh-dam-ibigroup. I say let's get this merged and start our final review of this.

[landonreed]

🎉 This PR is included in version 1.0.0-beta.1 🎉

The release is available on:

• npm package (@beta dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[landonreed]

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀