refactor(icons): move example custom icons into own file #164
Conversation
Codecov Report
@@ Coverage Diff @@
## otp-ui-icons #164 +/- ##
=============================================
Coverage 11.04% 11.04%
=============================================
Files 91 91
Lines 3612 3612
Branches 968 968
=============================================
Hits 399 399
Misses 2800 2800
Partials 413 413 Continue to review full report at Codecov.
|
example.js
Outdated
|
|
||
| // Set useCustomIcons to true to override classic icons with the exports from | ||
| // custom-icons.js | ||
| const useCustomIcons = true |
There was a problem hiding this comment.
This should be false by default.
example.js
Outdated
| // const MyLegIcon = () => <Ferry /> | ||
| // const MyModeIcon = () => <AerialTram /> |
There was a problem hiding this comment.
I am getting rid of this example in #150 in favor of the one using CustomIcons.
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Set useCustomIcons to false?
|
🎉 This PR is included in version 1.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Move things around a little to clean up the example/make it easier to override classic icons.