-
Notifications
You must be signed in to change notification settings - Fork 59
Test all routes for Accessibility issues #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Had to wrangle jest a little bit but now have this working. Most routes test nicely even without mock data, but I (for now) disabled all account paths from being tested -- the amount of calls we'd have to mock would take a long time to set up. However, it is easy to remove the flag disabling a11y checks, making future expansion here easy. Also ran into a weird codespell bug -- the word ignore list does NOT work. All it does is make the false positive error twice (once in the file, once in the config file) |
|
Amazing stuff! @binh-dam-ibigroup, could you take a look at these new tests? Feel free to merge if all looks good. |
|
@landonreed did you mean to assign me to #434? |
|
Sure, I'll just merge this one into #434 and assign you there. |
|
🎉 This PR is included in version 3.4.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR has changes for #434. It breaks out all routes in the app into an array so that we can TEST ALL THE THINGS!
But, the tests are all broken! So assigning to @miles-grant-ibigroup to see if he can pick this up and fix things. Might also be worth creating a parameterized framework.