Skip to content

Conversation

@landonreed
Copy link
Member

This PR has changes for #434. It breaks out all routes in the app into an array so that we can TEST ALL THE THINGS!

But, the tests are all broken! So assigning to @miles-grant-ibigroup to see if he can pick this up and fix things. Might also be worth creating a parameterized framework.

@miles-grant-ibigroup
Copy link
Collaborator

miles-grant-ibigroup commented Aug 19, 2021

Had to wrangle jest a little bit but now have this working. Most routes test nicely even without mock data, but I (for now) disabled all account paths from being tested -- the amount of calls we'd have to mock would take a long time to set up. However, it is easy to remove the flag disabling a11y checks, making future expansion here easy.

Also ran into a weird codespell bug -- the word ignore list does NOT work. All it does is make the false positive error twice (once in the file, once in the config file)

@landonreed
Copy link
Member Author

landonreed commented Aug 19, 2021

Amazing stuff! @binh-dam-ibigroup, could you take a look at these new tests? Feel free to merge if all looks good.

@binh-dam-ibigroup
Copy link
Collaborator

@landonreed did you mean to assign me to #434?

@landonreed
Copy link
Member Author

Sure, I'll just merge this one into #434 and assign you there.

@landonreed landonreed merged commit 7eee7b3 into further-a11y-fixes Aug 19, 2021
@landonreed landonreed deleted the a11y-all-paths branch August 19, 2021 18:04
@landonreed landonreed changed the title refactor: move routes to array for testing Test all routes for Accessibility issues Aug 23, 2021
@github-actions
Copy link
Contributor

🎉 This PR is included in version 3.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants