[toolbar] Add disabled attribute and legend support - #1421
Merged
Conversation
lukewarlow
requested review from
gregwhitworth,
keithamus and
mfreed7
as code owners
March 13, 2026 18:28
lukewarlow
marked this pull request as draft
March 13, 2026 18:28
Collaborator
Author
|
For now I've added styles that puts the first child legend as flex basis 100% so it's on its own line above the rest of the items. |
scottaohara
reviewed
Mar 13, 2026
scottaohara
left a comment
scottaohara
left a comment
Collaborator
There was a problem hiding this comment.
looks good. some suggestions for you to take or leave.
lukewarlow
force-pushed
the
toolbar-disabled-and-legend
branch
from
March 13, 2026 22:58
352f029 to
4d214fd
Compare
Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
lukewarlow
force-pushed
the
toolbar-disabled-and-legend
branch
from
March 13, 2026 23:04
4d214fd to
df0d7d2
Compare
lukewarlow
marked this pull request as ready for review
March 13, 2026 23:05
scottaohara
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a disabled attribute and child legend support to toolbar
Fixes #1399 and #1420