Skip to content

Add uni_vhsubps and uni_vaddsubps into jit_generator - #142

Merged
maxnick merged 5 commits into
openvinotoolkit:v2.6_for_ie_masterfrom
avoskoboinyk-lohika:add_hsubps_addsubps
Sep 21, 2022
Merged

Add uni_vhsubps and uni_vaddsubps into jit_generator#142
maxnick merged 5 commits into
openvinotoolkit:v2.6_for_ie_masterfrom
avoskoboinyk-lohika:add_hsubps_addsubps

Conversation

@avoskoboinyk-lohika

@avoskoboinyk-lohika avoskoboinyk-lohika commented Sep 2, 2022

Copy link
Copy Markdown

Description

Add VEX / non-VEX switch functions for hsubps and addsubps instructions into jit_generator component.

OpenVINO PR:

Comment thread src/cpu/x64/jit_generator.hpp Outdated
Comment thread src/cpu/x64/jit_generator.hpp Outdated
Comment thread src/cpu/x64/jit_generator.hpp Outdated
Comment thread src/cpu/x64/jit_generator.hpp Outdated
@lohika-denis-kotov

Copy link
Copy Markdown

Also, please, do not resolve comments leaved by reviewer. Answer on comment that either it is done: "Done", or any other feedback and let reviewer to resolve comments when see it

@ceciliapeng2011

Copy link
Copy Markdown
Collaborator

a part of DFT operation optimization (openvinotoolkit/openvino#11946)

@dmitry-gorokhov @luo-cheng2021 @usstq

@lohika-denis-kotov lohika-denis-kotov left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/cpu/x64/jit_generator.hpp
Comment thread src/cpu/x64/jit_generator.hpp Outdated
@ceciliapeng2011

Copy link
Copy Markdown
Collaborator

@maxnick Would you please have a look too? Thanks.

@maxnick
maxnick merged commit 167f937 into openvinotoolkit:v2.6_for_ie_master Sep 21, 2022
@avoskoboinyk-lohika
avoskoboinyk-lohika deleted the add_hsubps_addsubps branch September 21, 2022 12:44
EgorDuplensky pushed a commit that referenced this pull request Sep 22, 2022
* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1
EgorDuplensky pushed a commit that referenced this pull request Sep 23, 2022
* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1
EgorDuplensky pushed a commit that referenced this pull request Sep 27, 2022
* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1
EgorDuplensky pushed a commit that referenced this pull request Oct 4, 2022
* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1
luweizhou2016 pushed a commit that referenced this pull request Jun 29, 2023
* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1
luweizhou2016 pushed a commit that referenced this pull request Dec 20, 2023
* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1
luweizhou2016 pushed a commit that referenced this pull request Jan 10, 2024
* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1
luweizhou2016 pushed a commit that referenced this pull request Jan 24, 2024
* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1
luweizhou2016 pushed a commit that referenced this pull request Jun 14, 2024
* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1
luweizhou2016 pushed a commit that referenced this pull request Jul 18, 2024
* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1
luweizhou2016 pushed a commit that referenced this pull request Jul 19, 2024
* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1
luweizhou2016 pushed a commit that referenced this pull request Jul 24, 2024
Remove redundancy of two unified instructions

3.5 squash below:
[FIX] Add uni_vhsubps and uni_vaddsubps into jit_generator (#142)

* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1

[FIX] added uni_vcvttps2dq
luweizhou2016 pushed a commit that referenced this pull request Jul 25, 2024
Remove redundancy of two unified instructions

3.5 squash below:
[FIX] Add uni_vhsubps and uni_vaddsubps into jit_generator (#142)

* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1

[FIX] added uni_vcvttps2dq
luweizhou2016 pushed a commit that referenced this pull request Jul 29, 2024
Remove redundancy of two unified instructions

3.5 squash below:
[FIX] Add uni_vhsubps and uni_vaddsubps into jit_generator (#142)

* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1

[FIX] added uni_vcvttps2dq
azhai219 pushed a commit that referenced this pull request Dec 4, 2024
Remove redundancy of two unified instructions

3.5 squash below:
[FIX] Add uni_vhsubps and uni_vaddsubps into jit_generator (#142)

* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1

[FIX] added uni_vcvttps2dq
azhai219 pushed a commit to azhai219/oneDNN that referenced this pull request Dec 6, 2024
Remove redundancy of two unified instructions

3.5 squash below:
[FIX] Add uni_vhsubps and uni_vaddsubps into jit_generator (openvinotoolkit#142)

* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1

[FIX] added uni_vcvttps2dq
azhai219 pushed a commit to azhai219/oneDNN that referenced this pull request Mar 26, 2025
Remove redundancy of two unified instructions

3.5 squash below:
[FIX] Add uni_vhsubps and uni_vaddsubps into jit_generator (openvinotoolkit#142)

* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1

[FIX] added uni_vcvttps2dq
azhai219 pushed a commit to azhai219/oneDNN that referenced this pull request Apr 8, 2025
Remove redundancy of two unified instructions

3.5 squash below:
[FIX] Add uni_vhsubps and uni_vaddsubps into jit_generator (openvinotoolkit#142)

* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1

[FIX] added uni_vcvttps2dq
azhai219 pushed a commit to azhai219/oneDNN that referenced this pull request Apr 9, 2025
Remove redundancy of two unified instructions

3.5 squash below:
[FIX] Add uni_vhsubps and uni_vaddsubps into jit_generator (openvinotoolkit#142)

* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1

[FIX] added uni_vcvttps2dq
azhai219 pushed a commit to azhai219/oneDNN that referenced this pull request Apr 14, 2025
Remove redundancy of two unified instructions

3.5 squash below:
[FIX] Add uni_vhsubps and uni_vaddsubps into jit_generator (openvinotoolkit#142)

* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1

[FIX] added uni_vcvttps2dq
azhai219 pushed a commit to azhai219/oneDNN that referenced this pull request Jun 17, 2025
Remove redundancy of two unified instructions

3.5 squash below:
[FIX] Add uni_vhsubps and uni_vaddsubps into jit_generator (openvinotoolkit#142)

* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1

[FIX] added uni_vcvttps2dq
azhai219 pushed a commit to azhai219/oneDNN that referenced this pull request Jun 18, 2025
Remove redundancy of two unified instructions

3.5 squash below:
[FIX] Add uni_vhsubps and uni_vaddsubps into jit_generator (openvinotoolkit#142)

* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1

[FIX] added uni_vcvttps2dq
azhai219 pushed a commit to azhai219/oneDNN that referenced this pull request Jun 20, 2025
Remove redundancy of two unified instructions

3.5 squash below:
[FIX] Add uni_vhsubps and uni_vaddsubps into jit_generator (openvinotoolkit#142)

* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1

[FIX] added uni_vcvttps2dq
azhai219 pushed a commit to azhai219/oneDNN that referenced this pull request Jun 20, 2025
Remove redundancy of two unified instructions

3.5 squash below:
[FIX] Add uni_vhsubps and uni_vaddsubps into jit_generator (openvinotoolkit#142)

* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1

[FIX] added uni_vcvttps2dq
azhai219 pushed a commit to azhai219/oneDNN that referenced this pull request Oct 27, 2025
Remove redundancy of two unified instructions

3.5 squash below:
[FIX] Add uni_vhsubps and uni_vaddsubps into jit_generator (openvinotoolkit#142)

* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1

[FIX] added uni_vcvttps2dq
azhai219 pushed a commit to azhai219/oneDNN that referenced this pull request Nov 24, 2025
Remove redundancy of two unified instructions

3.5 squash below:
[FIX] Add uni_vhsubps and uni_vaddsubps into jit_generator (openvinotoolkit#142)

* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1

[FIX] added uni_vcvttps2dq
azhai219 pushed a commit to azhai219/oneDNN that referenced this pull request Dec 5, 2025
Remove redundancy of two unified instructions

3.5 squash below:
[FIX] Add uni_vhsubps and uni_vaddsubps into jit_generator (openvinotoolkit#142)

* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1

[FIX] added uni_vcvttps2dq
azhai219 pushed a commit to azhai219/oneDNN that referenced this pull request Dec 17, 2025
Remove redundancy of two unified instructions

3.5 squash below:
[FIX] Add uni_vhsubps and uni_vaddsubps into jit_generator (openvinotoolkit#142)

* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1

[FIX] added uni_vcvttps2dq
azhai219 pushed a commit to azhai219/oneDNN that referenced this pull request Mar 17, 2026
Remove redundancy of two unified instructions

3.5 squash below:
[FIX] Add uni_vhsubps and uni_vaddsubps into jit_generator (openvinotoolkit#142)

* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1

[FIX] added uni_vcvttps2dq

(cherry picked from commit 7a63835)
azhai219 pushed a commit to azhai219/oneDNN that referenced this pull request Jul 13, 2026
Remove redundancy of two unified instructions

3.5 squash below:
[FIX] Add uni_vhsubps and uni_vaddsubps into jit_generator (openvinotoolkit#142)

* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1

[FIX] added uni_vcvttps2dq

(cherry picked from commit 7a63835)
azhai219 pushed a commit that referenced this pull request Aug 10, 2026
Remove redundancy of two unified instructions

3.5 squash below:
[FIX] Add uni_vhsubps and uni_vaddsubps into jit_generator (#142)

* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1

[FIX] added uni_vcvttps2dq

(cherry picked from commit 7a63835)
azhai219 pushed a commit that referenced this pull request Aug 18, 2026
Remove redundancy of two unified instructions

3.5 squash below:
[FIX] Add uni_vhsubps and uni_vaddsubps into jit_generator (#142)

* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1

[FIX] added uni_vcvttps2dq

(cherry picked from commit 7a63835)
(cherry picked from commit 79dbb36)
azhai219 pushed a commit that referenced this pull request Aug 19, 2026
Remove redundancy of two unified instructions

3.5 squash below:
[FIX] Add uni_vhsubps and uni_vaddsubps into jit_generator (#142)

* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1

[FIX] added uni_vcvttps2dq
azhai219 pushed a commit that referenced this pull request Aug 25, 2026
Remove redundancy of two unified instructions

3.5 squash below:
[FIX] Add uni_vhsubps and uni_vaddsubps into jit_generator (#142)

* Add uni_vhsubps and uni_vaddsubps into jit_generator.hpp

* Add missing namespace

* Adjust indentation and add braces

* Improve formatting

* Replace assertion in uni_vhsubps and uni_vhaddps with possible workaround for SSE 4.1

[FIX] added uni_vcvttps2dq
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants