Skip to content

support (src_f32,wei_fp16,dst_f32) in ip - #246

Merged
dmitry-gorokhov merged 1 commit into
v3.3_for_ie_masterfrom
tq/wei-f16-ip
May 21, 2024
Merged

support (src_f32,wei_fp16,dst_f32) in ip#246
dmitry-gorokhov merged 1 commit into
v3.3_for_ie_masterfrom
tq/wei-f16-ip

Conversation

@usstq

@usstq usstq commented Apr 23, 2024

Copy link
Copy Markdown

Description

Add support for (src_f32, weight_f16, dst_f32) in inner product

Fixes CVS-133453

Checklist

General

  • Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  • Have you formatted the code using clang-format?

Performance improvements

  • Have you submitted performance data that demonstrates performance improvements?

New features

  • Have you published an RFC for the new feature?
  • Was the RFC approved?
  • Have you added relevant tests?

Bug fixes

  • Have you included information on how to reproduce the issue (either in a github issue or in this PR)?
  • Have you added relevant regression tests?

RFC PR

  • Does RFC document follow the template?
  • Have you added a link to the rendered document?

CPU_INSTANCE_AVX512(brgemm_inner_product_fwd_t, avx512_core)
CPU_INSTANCE_AVX2(brgemm_inner_product_fwd_t, avx2)
nullptr,
}},

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you, please, provide a use case for such configuration?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dzarukin. This is needed for LLMs with fp16 compressed weights (lower speedup than for u8/u4 compressed weights, but no accuracy loss comparing with fp32).

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmitry-gorokhov thanks for explaining. Should oneDNN follow the same path and add such configurations support to the library?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dzarukin I would highly recommend to do that. Pretty cheap optimization in terms of implementation effort, but very benefitial for LLMs at the same time. Should be useful for majority of DL frameworks focusing on edge inference, since weights conversion to FP16 doesn't require any fine-tuning/complex compression techniques,

@usstq
usstq force-pushed the tq/wei-f16-ip branch 2 times, most recently from 577bbce to 9cc2b8c Compare May 15, 2024 06:35
github-merge-queue Bot pushed a commit to openvinotoolkit/openvino that referenced this pull request May 21, 2024
### Details:
 - *Add support for (src_f32, weight_f16) case in FC*

oneDNN-fork PR: openvinotoolkit/oneDNN#246

### Tickets:
 - *CVS-133453*
 - *CVS-139274*
@dmitry-gorokhov
dmitry-gorokhov merged commit ddd4dd4 into v3.3_for_ie_master May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants