Skip to content

Conversation

@mgage
Copy link
Member

@mgage mgage commented Jul 2, 2021

this includes commits in @taniwallach 's " docker-two-stage-build.... " -- I didn't have permission to submit a pull request directly to tani's github repos.

taniwallach and others added 14 commits June 10, 2021 20:09
Modify startup so that
	docker container exec -it webwork2_app_1 /usr/sbin/apachectl graceful
can be used to restart Apache in the container in a "nice" way without
stopping the running container.
Minor fixes.
…: admin with password: admin to the course admin
… or the library browser will complain. 2. make www-data the owner of htdocs/tmp with write privileges
@mgage
Copy link
Member Author

mgage commented Jul 2, 2021

this includes @taniwallach repos "docker-two-stage...." branch

added instructions for creating a webwork docker box with minimal configuration (out of the box)
www-data is made owner of webwork2/htdocs/tmp to prevent errors when creating courses
added vim and less to ADD_APT_PACKAGES

don't run
#$WEBWORK_ROOT/bin/upgrade_admin_db.pl
#$WEBWORK_ROOT/wwsh admin ./addadmin
running upgrade_admin_db.pl may not be necessary -- although I think if the admin tables are not up todate it might cause trouble with running the admin course

@mgage mgage changed the title upPatch for docker two stage Patch for docker two stage Jul 2, 2021
@mgage mgage added the Do Not Merge Yet PR to allow others to inspect -- not ready for prime time label Jul 2, 2021
@taniwallach
Copy link
Member

If you are enabling the 2-stage build process as the default, then the instructions need to tell the user to run
docker build --tag webwork-base:forWW216 -f DockerfileStage1 . before they can run docker-compose up to do the second stage.

I still think that the instructions file probably belongs in some subdirectory.

@drgrice1
Copy link
Member

drgrice1 commented Jul 5, 2021

Now that @taniwallach's two stage docker build pull request has been merged you should be able to clean this up a bit. If you want to talk about how to do this well, let me know.

@mgage
Copy link
Member Author

mgage commented Jul 6, 2021

withdrawn in favor of #1435 patch5 version

@mgage mgage closed this Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do Not Merge Yet PR to allow others to inspect -- not ready for prime time

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants