Skip to content

Conversation

@taniwallach
Copy link
Member

This is intended to supplement what was just done as a hot fix in #1447 but to make it possible to configure a list of model courses which get prepended to the provided list.

drgrice1 and others added 2 commits July 15, 2021 13:52
…om-model-course

force modelCourse to be listed as template source
@drgrice1
Copy link
Member

I am not sure that this qualifies for a hotfix. This adds a new feature that was not present before. Generally that is something that should not be added after the release.

@taniwallach
Copy link
Member Author

Yes and no. In the past - just about any directory in the courses directory could be used as a the source of the templates directory, as listCourses included them (so long as they avoided some regular expression conditions). This provides an option to optionally define selected directories (other than the fixed modelCourse) to be included in the list. So it reenables more of the prior functionality, but in a controlled manner.

It can certainly be put in develop instead (or dropped). Whatever the team prefers.

Copy link
Member

@pstaabp pstaabp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. Technically not a hot fix, but functionality nearly equivalent and more flexible.

@drgrice1
Copy link
Member

I see. I suppose that could be hotfix worthy if that is something that was commonly utilized. What do others thing on this?

Copy link
Member

@drdrew42 drdrew42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does give an alternative for the options that were available before listCourses was modified.

@drgrice1
Copy link
Member

Okay. A hotfix it can be then.

Copy link
Member

@drgrice1 drgrice1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge and also add it to develop.

@drgrice1 drgrice1 merged commit 48b9fea into openwebwork:main Jul 15, 2021
@taniwallach taniwallach deleted the configurable-modelcourses-for-admin-add-course branch July 16, 2021 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants