-
-
Notifications
You must be signed in to change notification settings - Fork 166
Configurable modelcourses list for admin add course #1448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable modelcourses list for admin add course #1448
Conversation
…om-model-course force modelCourse to be listed as template source
…tion via admin course.
|
I am not sure that this qualifies for a hotfix. This adds a new feature that was not present before. Generally that is something that should not be added after the release. |
|
Yes and no. In the past - just about any directory in the courses directory could be used as a the source of the templates directory, as It can certainly be put in develop instead (or dropped). Whatever the team prefers. |
pstaabp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good. Technically not a hot fix, but functionality nearly equivalent and more flexible.
|
I see. I suppose that could be hotfix worthy if that is something that was commonly utilized. What do others thing on this? |
drdrew42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does give an alternative for the options that were available before listCourses was modified.
|
Okay. A hotfix it can be then. |
drgrice1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will merge and also add it to develop.
This is intended to supplement what was just done as a hot fix in #1447 but to make it possible to configure a list of model courses which get prepended to the provided list.