Do not UTF-8 encode email body text. (for develop)#1818
Merged
pstaabp merged 1 commit intoopenwebwork:developfrom Oct 29, 2022
Merged
Do not UTF-8 encode email body text. (for develop)#1818pstaabp merged 1 commit intoopenwebwork:developfrom
pstaabp merged 1 commit intoopenwebwork:developfrom
Conversation
drgrice1
force-pushed
the
bugfix/no-encode-email-messages-develop
branch
from
3665f12 to
91bccbf
Compare
drgrice1
changed the title
taniwallach
approved these changes
Oct 24, 2022
Member
taniwallach
left a comment
taniwallach
left a comment
There was a problem hiding this comment.
Tested the PR to main. These are the same changes.
pstaabp
approved these changes
Oct 25, 2022
The Email::Stuffer package tries to automatically detect if the body needs to be UTF-8 encoded (either that or it just does so by default), and so if you UTF-8 encode the message first, then Email::Stuffer does it again resulting in "Mojibake". This is openwebwork#1817 for develop.
drgrice1
force-pushed
the
bugfix/no-encode-email-messages-develop
branch
from
91bccbf to
0c06beb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Email::Stuffer package tries to automatically detect if the body needs to be UTF-8 encoded (either that or it just does so by default), and so if you UTF-8 encode the message first, then Email::Stuffer does it again resulting in "Mojibake".
This is #1817 for develop.