Conversation
|
When I first clicked on the Tag Editor, I wasn't sure what the number was on the bottom row. The other seem clear, but I wonder if we should label each of them? I also wonder if a popup is the best UI for this. If you are just looking for the Subject/Chapter/Section tags, you need to open up the dialog and then close it. Maybe dynamically showing a row of select just above the problem might be nicer--I think this is similar to how it was before. |
|
I thought of adding labels. I will do that. The dialog is way better. There is no need to have the tags in the page. The row will never work nicely. That is simply impossible. This is the same problem your current design of the webwork3 library browser has. You just cannot fit long text like this into a single line. If you want to see the tags, simply click on the button. It opens quickly and there you have it. |
|
By the way, as to the labels, this is the same as it was before without the labels. |
drgrice1
force-pushed
the
tag-widget-update
branch
from
7011823 to
8e82805
Compare
|
I added labels to the selects in the dialog. Also, I eliminated the nonsensical "All ..." option that was used for the default option in each select to mean no subject is selected. Instead "Select ..." is used. |
drgrice1
force-pushed
the
tag-widget-update
branch
2 times, most recently
from
40d5050 to
4aa19e0
Compare
drgrice1
force-pushed
the
tag-widget-update
branch
from
4aa19e0 to
d75f08e
Compare
|
This is great. I am no longer bombarded with alerts when a problem isn't properly tagged... My only suggestion for improvement is to replace the "Select _____" option with the invalid subject/chapter/section at the top of the dropdown list instead of appending it as the last option. |
drgrice1
force-pushed
the
tag-widget-update
branch
from
d75f08e to
d213b23
Compare
|
@drdrew42: I made your suggested change. Invalid tags are now added at the beginning and the 'Select ...' option removed. |
The javascript is updated with javascript that does not use jQuery. Furthermore, the old widget that was directly displayed in the page and was ugly as hell has been replaced with a button. When the button is clicked a dialog opens with a dialog which contains the tag editor. If a problem has invalid tags, instead of those intrusive native alert dialogs a toast is shown. The user can continue to interact with the page even while the toast is present. The toast disappears after five seconds on its own.
Also replace the "all" text with a better default option. "All Subjects" doesn't make sense to mean no subject is selected. So this uses "Select Subject" instead.
with the invalid tag at the top of the dropdown instead of appending it to the end.
drgrice1
force-pushed
the
tag-widget-update
branch
from
5df0f09 to
2e54b7f
Compare
This was an accidental regression in openwebwork#1887. This fixes openwebwork#1913.
3 participants
The javascript is updated with javascript that does not use jQuery.
Furthermore, the old widget that was directly displayed in the page and was ugly as hell has been replaced with a button. When the button is clicked a dialog opens with a dialog which contains the tag editor.
If a problem has invalid tags, instead of those intrusive native alert dialogs a toast is shown. The user can continue to interact with the page even while the toast is present. The toast disappears after five seconds on its own.
Note for self: This has conflicts with #1884.