Skip to content

Correct the problem numbers when a set definition file is imported. #2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Correct the problem numbers when a set definition file is imported. #2254

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9734d71
Correct the problem numbers when a set definition file is imported.
drgrice1 Nov 15, 2023
fa9ea06
Fix how invalid problem ids from set definition files are handled.
drgrice1 Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/WeBWorK/File/SetDef.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,13 +194,13 @@ sub importSetsFromDef ($ce, $db, $setDefFiles, $existingSets = undef, $assign =

debug("$set_definition_file: adding problems to database");
# Add problems
my $freeProblemID = WeBWorK::Utils::max($db->listGlobalProblems($setData->{setID})) + 1;
my $freeProblemID = WeBWorK::Utils::max(grep {$_} map { $_->{problem_id} } @{ $setData->{problemData} }) + 1;
for my $rh_problem (@{ $setData->{problemData} }) {
addProblemToSet(
$db, $ce->{problemDefaults},
setName => $setData->{setID},
sourceFile => $rh_problem->{source_file},
problemID => $rh_problem->{problemID} ? $rh_problem->{problemID} : $freeProblemID++,
problemID => $rh_problem->{problem_id} || $freeProblemID++,
value => $rh_problem->{value},
maxAttempts => $rh_problem->{max_attempts},
showMeAnother => $rh_problem->{showMeAnother},
Expand Down