Fix course listings in the admin course. #2350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are three lines of code changed. Line 53 of `templates/ContentGenerator/CourseAdmin.html.ep` was deleted. That line should not exist. That saves a list of all courses to the `@courseIDs` variable that is never used. The `listCourses` method is called again on line 56 (now 55). On line 56 (now 55) of that same file, the admin course is omitted from the listing. This is how it used to be, and was removed in openwebwork#2295. I don't believe that the admin course should be listed on the admin course listings page. On line 110 of `templates/ContentGenerator/CourseAdmin/add_course_form.html.ep` the admin course is kept in the listing. This is the list of courses that can be copied. This was how it was set up in openwebwork#2295, but was reverted in openwebwork#2290 (probably in merge resolution, or maybe my changes to that pull request?). The intent was to allow the admin course to be copied to change to a new course to use for the admin course. The first line changed is not controversial, but the second two are up for discussion.
drgrice1
force-pushed
the
admin-course-listings
branch
from
ae6190a to
b508860
Compare
pstaabp
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three lines of code changed.
Line 53 of
templates/ContentGenerator/CourseAdmin.html.epwas deleted. That line should not exist. That saves a list of all courses to the@courseIDsvariable that is never used. ThelistCoursesmethod is called again on line 56 (now 55).On line 56 (now 55) of that same file, the admin course is omitted from the listing. This is how it used to be, and was removed in #2295. I don't believe that the admin course should be listed on the admin course listings page.
On line 110 of
templates/ContentGenerator/CourseAdmin/add_course_form.html.epthe admin course is kept in the listing. This is the list of courses that can be copied. This was how it was set up in #2295, but was reverted in #2290 (probably in merge resolution, or maybe my changes to that pull request?). The intent was to allow the admin course to be copied to change to a new course to use for the admin course.The first line changed is not controversial, but the second two are up for discussion.