Rework PG error/warning/debug message handling.#2935
Open
drgrice1 wants to merge 1 commit intoopenwebwork:developfrom
Open
Rework PG error/warning/debug message handling.#2935drgrice1 wants to merge 1 commit intoopenwebwork:developfrom
drgrice1 wants to merge 1 commit intoopenwebwork:developfrom
Conversation
Member
Author
|
Note that this pull request is necessary to test openwebwork/pg#1386. However, this pull request does not require that one. So this pull request can be tested with @somiaj's pull request referenced above. |
Member
Author
|
Here is a problem you can use to test the various warnings: |
Member
Author
|
Also, you can test debugging messages with the check boxes that appear when viewing a problem in a set as an admin user. You can also test debugging messages with @somiaj's pull request and a problem that has formula diagnostics enabled. |
The PG messages are now dealt with completely separately from the webwork2 general warning handling. Furthermore PG warnings and debug messages are separately dealt with. The PG `internal_debug_messages` are no longer dealt with at all. They are unnecessary and inappropriately named, and will be removed from PG. Also, handling of the warnings is now much more consistent in all of the different places that problems are rendered. In fact, they all use the new `templates/ContentGenerator/Base/problem_warning_and_debug_output.html.ep` template for this. All of this output is no longer wrapped in a `code` tag. That is the wrong thing for this. None of it is code. It also causes problems with openwebwork/pg#1384.
bee704d to
01f4401
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PG messages are now dealt with completely separately from the webwork2 general warning handling. Furthermore PG warnings and debug messages are separately dealt with.
The PG
internal_debug_messagesare no longer dealt with at all. They are unnecessary and inappropriately named, and will be removed from PG.Also, handling of the warnings is now much more consistent in all of the different places that problems are rendered. In fact, they all use the new
templates/ContentGenerator/Base/problem_warning_and_debug_output.html.eptemplate for this.All of this output is no longer wrapped in a
codetag. That is the wrong thing for this. None of it is code. It also causes problems with openwebwork/pg#1384.