Skip to content

Fix issues with reseting two-factor authentication in the accounts manager. #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alex-Jordan merged 1 commit into from
May 27, 2026
Merged

Fix issues with reseting two-factor authentication in the accounts manager. #2988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions lib/WeBWorK/ContentGenerator/Instructor/UserList.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,13 @@ use constant FORM_TITLES => {

# permissions needed to perform a given action
use constant FORM_PERMS => {
save_edit => 'modify_student_data',
edit => 'modify_student_data',
reset2_2fa => 'change_password',
import => 'modify_student_data',
export => 'modify_classlist_files',
add => 'modify_student_data',
delete => 'modify_student_data',
save_edit => 'modify_student_data',
edit => 'modify_student_data',
reset_2fa => 'change_password',
import => 'modify_student_data',
export => 'modify_classlist_files',
add => 'modify_student_data',
delete => 'modify_student_data',
};

use constant SORT_SUBS => {
Expand Down Expand Up @@ -504,10 +504,11 @@ sub reset_2fa_handler ($c) {
push @resultText, $c->maketext('You are not allowed to reset two factor authenticatio for [_1].', $userID);
next;
}
my $password = $db->getPassword($userID);
$password->otp_secret('');
$db->putPassword($password);
$num++;
if (my $password = $db->getPassword($userID)) {
$password->otp_secret('');
$db->putPassword($password);
}
++$num;
}

unshift @resultText, $c->maketext('Reset two factor authentication for [quant,_1,user].', $num);
Expand Down
Loading