Skip to content

Gateway Answer Bug #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
goehle wants to merge 2 commits into from
Closed

Gateway Answer Bug #740

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de1c579
Made it so you can see correct answers and solutions on gateways when…
goehle Sep 1, 2016
f97dc30
Checking for undefined variable.
goehle Sep 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions lib/WeBWorK/ContentGenerator/GatewayQuiz.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,15 +101,15 @@ sub can_showCorrectAnswers {
# so we should hide the correct answers if we aren not showing
# scores GG.

my $canShowScores = $Set->hide_score_by_problem eq 'N' &&
my $canShowScores = ($Set->hide_score_by_problem eq 'N' ||
!$Set->hide_score_by_problem) &&
( $Set->hide_score eq 'N' ||
( $Set->hide_score eq 'BeforeAnswerDate' &&
after($tmplSet->answer_date) ) );

return ( ( ( after( $Set->answer_date ) ||
( $attemptsUsed >= $maxAttempts &&
$maxAttempts != 0 &&
$Set->due_date() == $Set->answer_date() ) ) ||
$maxAttempts != 0 ) ) ||
$authz->hasPermissions($User->user_id,
"show_correct_answers_before_answer_date") ) &&
( $authz->hasPermissions($User->user_id, "view_hidden_work") ||
Expand Down Expand Up @@ -147,15 +147,15 @@ sub can_showSolutions {
# so we should hide the correct answers if we aren not showing
# scores GG.

my $canShowScores = $Set->hide_score_by_problem eq 'N' &&
my $canShowScores = ($Set->hide_score_by_problem eq 'N' ||
!$Set->hide_score_by_problem) &&
( $Set->hide_score eq 'N' ||
( $Set->hide_score eq 'BeforeAnswerDate' &&
after($tmplSet->answer_date) ) );

return ( ( ( after( $Set->answer_date ) ||
( $attemptsUsed >= $attempts_per_version &&
$attempts_per_version != 0 &&
$Set->due_date() == $Set->answer_date() ) ) ||
$attempts_per_version != 0 ) ) ||
$authz->hasPermissions($User->user_id,
"show_correct_answers_before_answer_date") ) &&
( $authz->hasPermissions($User->user_id, "view_hidden_work") ||
Expand Down Expand Up @@ -262,8 +262,8 @@ sub can_checkAnswers {
# showing correcrt answers but not showing scores doesn't make sense
# so we should hide the correct answers if we aren not showing
# scores GG.

my $canShowScores = $Set->hide_score_by_problem eq 'N' &&
my $canShowScores = ($Set->hide_score_by_problem eq 'N' ||
!$Set->hide_score_by_problem) &&
( $Set->hide_score eq 'N' ||
( $Set->hide_score eq 'BeforeAnswerDate' &&
after($tmplSet->answer_date) ) );
Expand Down