[packaging] Added conditional dependencies for wheel#74
[packaging] Added conditional dependencies for wheel#74nemesifier merged 1 commit intoopenwisp:masterfrom
Conversation
7867488 to
d108b85
Compare
|
@nemesisdesign I ran the tests locally on a clean virtualenv and it passed. |
nemesifier
left a comment
There was a problem hiding this comment.
Not sure what causes the problem on travis, I'm testing.
| continue | ||
| # add line to requirements | ||
| requirements.append(line.replace('\n', '')) | ||
| # add py2-ipaddress if python2 |
There was a problem hiding this comment.
not sure this block of code can be removed, it may still be required for non-wheel packages.
There was a problem hiding this comment.
no, I'm wrong. Ignore this! Good work.
There was a problem hiding this comment.
I was wrong again, that bit of code is necessary for non-wheel packages (old fashion tar.gz).
There was a problem hiding this comment.
How did you test it ?
There was a problem hiding this comment.
you can test it by generating the packages with:
python setup.py sdist bdist_wheel
Then create 2 new virtualenvs, one with python2 and one with python3, and in each virtualenv you do:
pip install -U pip wheel setuptools
pip install -r requirements-test.txt
Then, for each virtualenv you do:
cd dist/
pip install ./<name-of-tar.gz-package>
cd ..
./runtests.py
I did the same also for the wheel package (uninstalling the dependencies and reinstalling the package).
Without this test we would risk to release a broken package and would piss many people off!
There was a problem hiding this comment.
Good to know. 👍
|
I can reproduce the travis issue wit the following procedure: git clone https://github.com/ritwickdsouza/netjsonconfig.git tmp-netjsonconfig
cd tmp-netjsonconfig
git checkout cond-depend-wheel
mkvirtualenv tmp --python=/usr/bin/python3
pip install -U pip wheel setuptools
python setup.py develop
pip install -r requirements-test.txt
nosetests |
|
@ritwickdsouza keep me up to date (I suppose you are busy with your exams) |
|
@nemesisdesign Yeah, was busy with exams. Anyway I had introduced the bug by mistake. Works fine now. |
0badc8b to
15c435b
Compare
|
Also, please rebase from master with: git checkout master
git pull https://github.com/openwisp/netjsonconfig.git master
git checkout cond-depend-wheel
git rebase master |
15c435b to
10027ad
Compare
10027ad to
ce4d39b
Compare
References #72