[tests] Add missing sample_config admin tests on 1.1#995
Closed
asmodehn wants to merge 2 commits into
Closed
Conversation
3c06f57 to
fb3ded5
Compare
nemesifier
reviewed
Mar 27, 2025
Member
nemesifier
left a comment
There was a problem hiding this comment.
Great work @asmodehn, I see only 1 failing test in the build:
FAIL: test_device_with_config_change_deactivate_deactivate (openwisp2.sample_config.tests.TestTransactionAdmin)
This test checks the following things
----------------------------------------------------------------------
Traceback (most recent call last):
File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/unittest/case.py", line 59, in testPartExecutor
yield
File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/unittest/case.py", line 592, in run
self._callTestMethod(testMethod)
File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/unittest/case.py", line 550, in _callTestMethod
method()
File "/home/runner/work/openwisp-controller/openwisp-controller/openwisp_controller/config/tests/test_admin.py", line 2116, in test_device_with_config_change_deactivate_deactivate
self.assertContains(
File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/site-packages/django/test/testcases.py", line 466, in assertContains
self.assertEqual(
File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/unittest/case.py", line 837, in assertEqual
assertion_func(first, second, msg=msg)
File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/unittest/case.py", line 830, in _baseAssertEqual
raise self.failureException(msg)
AssertionError: 23 != 22 : Found 23 instances of '<div class="readonly">' in response (expected 22)
5c688b0 to
cdda721
Compare
4 tasks
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
This PR adds tests that seemed to be missing among the sample_config tests
This is currently a draft to check tests behaviour in the pipeline, using 1.1 as my current setup.
I plan to rebase on master later on.