Skip to content

[ci] Update PR validation workflow - #545

Merged
nemesifier merged 1 commit into
masterfrom
ci/update-pr-validation-workflow
Jul 30, 2026
Merged

[ci] Update PR validation workflow#545
nemesifier merged 1 commit into
masterfrom
ci/update-pr-validation-workflow

Conversation

@nemesifier

@nemesifier nemesifier commented Jul 29, 2026

Copy link
Copy Markdown
Member

Checklist

  • I have read the OpenWISP Contributing Guidelines and OpenWISP Anti AI Spam Policy.
  • N/A. This GitHub Actions caller-workflow change has no local manual execution path.
  • N/A. No application code changed.
  • N/A. No user-facing behavior or documentation changed.

Reference to Existing Issue

Related to openwisp/openwisp-utils#716

Description of Changes

Adds edited and ready_for_review pull request events so the shared workflow promptly revalidates changed descriptions. Makes the concurrency key PR-specific so newer events cancel outdated validation runs.

Screenshot

N/A. This is a GitHub Actions workflow-only change.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The pull request workflow now runs for edited and ready_for_review events in addition to its existing events. Its concurrency group is keyed by repository and pull request number, excluding the event action.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 8
✅ Passed checks (8 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Bug Fixes ✅ Passed Workflow-only GitHub Actions change; no core user-facing bug fix or regression test is expected under the workflow exception.
Features ✅ Passed CI workflow-only change; the feature-request UI/docs/tests/screenshot requirements don’t apply here.
Changes ✅ Passed PASS: Change is workflow-only; no documented behavior, UI, or public API is affected, and no workflow-specific tests/docs exist to update.
General Rules ✅ Passed Workflow change is compact, follows repo guidance, and adds no obvious security, perf, naming, or formatting issues; no tests are applicable here.
Title check ✅ Passed The title is descriptive, uses the required [ci] prefix, and matches the workflow validation changes.
Description check ✅ Passed The description includes all required sections; the issue reference format differs, but the template is mostly satisfied.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/update-pr-validation-workflow

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kilo-code-bot kilo-code-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[WARNING]: Concurrency group change may cancel needed runs

Removing ${{ github.event.action }} from the concurrency group means all events for the same PR now share the same concurrency slot. With cancel-in-progress: true, an edited or ready_for_review event can cancel an in-progress opened/reopened run. If a PR is edited (e.g. description change) while the auto-assignment workflow is still running, the auto-assignment will be cancelled and may never complete.


Reply with @kilocode-bot fix it to have Kilo Code address this issue.

pull-requests: read
concurrency:
group: bot-autoassign-pr-link-${{ github.repository }}-${{ github.event.pull_request.number }}-${{ github.event.action }}
group: bot-autoassign-pr-link-${{ github.repository }}-${{ github.event.pull_request.number }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[WARNING]: Concurrency group change may cancel needed runs

Removing ${{ github.event.action }} from the concurrency group means all events for the same PR now share the same concurrency slot. With cancel-in-progress: true, an edited or ready_for_review event can cancel an in-progress opened/reopened run. If a PR is edited (e.g. description change) while the auto-assignment workflow is still running, the auto-assignment will be cancelled and may never complete.


Reply with @kilocode-bot fix it to have Kilo Code address this issue.

@kilo-code-bot

kilo-code-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
.github/workflows/bot-autoassign-pr-issue-link.yml 10 Removing ${{ github.event.action }} from the concurrency group causes edited and ready_for_review events to share the same concurrency slot as opened/reopened runs. With cancel-in-progress: true, an edited or ready_for_review event can cancel an in-progress auto-assignment run, potentially leaving PRs unassigned if the PR is edited during the assignment process.
Files Reviewed (1 file)
  • .github/workflows/bot-autoassign-pr-issue-link.yml - 1 issue

Fix these issues in Kilo Cloud


Reviewed by ling-3.0-flash-free · Input: 24.5K · Output: 13.5K · Cached: 282.6K

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/bot-autoassign-pr-issue-link.yml:
- Line 7: Move the workflow-level issues: write permission into the
jobs.auto-assign-issue job’s permissions block, removing it from global workflow
permissions so only that reusable-workflow invocation receives issue-write
access.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ae112d77-8125-47a3-96b1-bd42e0ab192a

📥 Commits

Reviewing files that changed from the base of the PR and between 3b6653d and 6ea9ca4.

📒 Files selected for processing (1)
  • .github/workflows/bot-autoassign-pr-issue-link.yml
📜 Review details
⏰ Context from checks skipped due to timeout. (1)
  • GitHub Check: Kilo Code Review
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2026-04-17T20:35:58.550Z
Learnt from: nemesifier
Repo: openwisp/openwisp-users PR: 496
File: .github/workflows/bot-changelog-runner.yml:27-27
Timestamp: 2026-04-17T20:35:58.550Z
Learning: In the openwisp/openwisp-users repository, do not require pinning GitHub Actions to full commit SHAs for supply-chain security. It’s acceptable to reference actions using mutable major version tags like `actions/download-artifactv4`. When reviewing workflow YAML files, avoid raising comments specifically about SHA pinning for GitHub Actions in this repo.

Applied to files:

  • .github/workflows/bot-autoassign-pr-issue-link.yml
🪛 zizmor (1.28.0)
.github/workflows/bot-autoassign-pr-issue-link.yml

[error] 7-7: overly broad permissions (excessive-permissions): issues: write is overly broad at the workflow level

(excessive-permissions)


[warning] 7-7: permissions without explanatory comments (undocumented-permissions): needs an explanatory comment

(undocumented-permissions)

🔇 Additional comments (1)
.github/workflows/bot-autoassign-pr-issue-link.yml (1)

4-4: LGTM!

Also applies to: 9-10

Comment thread .github/workflows/bot-autoassign-pr-issue-link.yml
@nemesifier
nemesifier merged commit 4e5c422 into master Jul 30, 2026
29 checks passed
@nemesifier
nemesifier deleted the ci/update-pr-validation-workflow branch July 30, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant