Ensure OpenCL runtime and subprocess fallback#200
Merged
slarson merged 1 commit intoJun 29, 2025
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR improves the robustness of the simulation startup by warning if pyneuroml is not installed and providing a subprocess fallback to run commands. It also installs a CPU OpenCL driver in setup.sh and updates the test runner to warn about the missing module.
- In sibernetic_c302.py, the simulation command execution is modified to fall back to subprocess when pynml is unavailable.
- In setup.sh, additional OpenCL packages are added and pyneuroml installation is verified with a warning on failure.
- In run_all_tests.sh, the PYTHONPATH is updated more robustly and a warning is added if pyneuroml is missing.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sibernetic_c302.py | Adds subprocess fallback to command execution when pyneuroml is absent. |
| setup.sh | Installs additional OpenCL driver packages and verifies pyneuroml installation. |
| run_all_tests.sh | Updates PYTHONPATH computation and adds a warning for missing pyneuroml. |
| if res.returncode == 0: | ||
| completion_status = SUCCESS | ||
| else: | ||
| sys.stderr.write(res.stderr.decode()) |
There was a problem hiding this comment.
Consider using the existing print_ function for error output in the subprocess fallback branch to ensure consistent logging format with the rest of the application.
Suggested change
| sys.stderr.write(res.stderr.decode()) | |
| print_(res.stderr.decode()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pyneuromlmissing rather than aborting testssetup.shsibernetic_c302.pyfall back tosubprocesswhenpyneuromlisn't availableTesting
make -j$(nproc)./run_all_tests.sh./test.shhttps://chatgpt.com/codex/tasks/task_b_686185d49764832a8c117a5c2869496a