luci-app-led-nightmode: add LED night mode UI - #8998
Draft
mv-go wants to merge 1 commit into
Draft
Conversation
3 tasks
openwrt-ai
reviewed
Sep 2, 2026
openwrt-ai
left a comment
openwrt-ai
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed 1 new commit; 6 inline comments. The commit message matches the diff.
Main points: the custom postinst drops the rpcd reload that luci.mk normally performs, which the new ACL file needs; and the timezone-derived latitude/longitude are displayed but never persisted to UCI.
Noted for context (no action requested here): the +led-nightmode runtime and the luci.led-nightmode ubus object are not yet in the packages feed, but the PR description already calls out openwrt/packages#30426 as a prerequisite and marks this draft until then.
Generated by Claude Code
openwrt
Bot
added
the
not following guidelines
mv-go
force-pushed
the
luci-app-led-nightmode
branch
2 times, most recently
from
September 3, 2026 14:15
5fb3d87 to
053b9bf
Compare
openwrt
Bot
removed
the
not following guidelines
mv-go
force-pushed
the
luci-app-led-nightmode
branch
from
September 3, 2026 14:18
053b9bf to
f0282b1
Compare
openwrt-ai
reviewed
Sep 3, 2026
Add the native LuCI interface for the separately packaged led-nightmode runtime. Provide settings, scheduling controls, LED inventory, and provider controls. Add translations, menu metadata, and a least-privilege rpcd ACL. Keep hardware-specific provider implementations outside this LuCI contribution. Signed-off-by: Mv Go <rapture-ribose6k@icloud.com>
mv-go
force-pushed
the
luci-app-led-nightmode
branch
from
September 3, 2026 20:18
f0282b1 to
e35359f
Compare
openwrt-ai
reviewed
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the native LuCI interface for the separately packaged
led-nightmoderuntime.This Draft PR depends on openwrt/packages#30426. It should remain draft until the core package is accepted or otherwise available to the LuCI build.
The application provides:
The contribution is UI-only. UCI configuration, init scripts, CLI, service runners, rpcd executable, and generic provider API are owned by the linked
led-nightmodepackage. The hardware-specific Quectel provider is intentionally excluded.Validation completed:
build/i18n-scan.pl;apk-tools3 upgrade transaction from monolithic0.5.0-r8.The commit is SSH-signed and has a matching
Signed-off-by: Mv Go <rapture-ribose6k@icloud.com>.