Skip to content

tukan/cicada (no expansion delay / animation / nv.d3.css) fixes#876

Merged
fichtner merged 6 commits intoopnsense:masterfrom
opnsenseuser:tukan/cicada-(no-expansion-delay-/-animation-/-nv.d3.css)-fixes
Sep 30, 2018
Merged

tukan/cicada (no expansion delay / animation / nv.d3.css) fixes#876
fichtner merged 6 commits intoopnsense:masterfrom
opnsenseuser:tukan/cicada-(no-expansion-delay-/-animation-/-nv.d3.css)-fixes

Conversation

@opnsenseuser
Copy link
Copy Markdown
Member

no expansion delay / animation -> opnsense/core#2554
nv.d3.css fixes
other small fixes

no expansion delay / animation  -> opnsense/core#2554
nv.d3.css fixes
other small fixes
@fichtner fichtner self-assigned this Sep 28, 2018
@opnsenseuser
Copy link
Copy Markdown
Member Author

@marjohn56 just for your information

opnsenseuser added 5 commits September 28, 2018 19:10
+navigation optimisation (main.css + main.scss)
+collapsing (animation) not needed anymore
opacity fix
blanks fix
font-size fix and width fix for sidebar
fa.search fix
@fichtner
Copy link
Copy Markdown
Member

Good morning. Ready for pull or wait? :)

@opnsenseuser
Copy link
Copy Markdown
Member Author

Ready

@marjohn56
Copy link
Copy Markdown
Member

Does this fix the issue reported by a user in the forum with the firewall log widget?

@opnsenseuser
Copy link
Copy Markdown
Member Author

What report? Link ?

@marjohn56
Copy link
Copy Markdown
Member

@opnsenseuser
Copy link
Copy Markdown
Member Author

if it is this problem then it is a common problem. does he mean that? opnsense/core#2747

@marjohn56
Copy link
Copy Markdown
Member

It's fine with the default theme, only appears with our themes.

@opnsenseuser
Copy link
Copy Markdown
Member Author

@fichtner please wait with the pull.
@marjohn56 Screenshot?

@marjohn56
Copy link
Copy Markdown
Member

And it's there with any number of columns. This is mine with 3 columns.

image

@marjohn56
Copy link
Copy Markdown
Member

@fichtner - I seem to be making a habit of throwing in spanners at the last minute. 🤔

@fichtner
Copy link
Copy Markdown
Member

I'll fix the firewall widget tomorrow. I think this is a core issue with the widget structure itself.

@fichtner fichtner merged commit 0e98919 into opnsense:master Sep 30, 2018
@fichtner
Copy link
Copy Markdown
Member

Merged, thanks!

@marjohn56
Copy link
Copy Markdown
Member

Okey dokey. I'll go and update rebellion to match René's changes.

@opnsenseuser
Copy link
Copy Markdown
Member Author

@marjohn56 you're right.
But it's kinda weird because you've taken over the css code from opnsense theme 1: 1.
the problem should not occur with you, too

@fichtner in the production environment, the problem really only occurs in our(dark, cicada, tukan) themes. in the development environment for all themes (also opnsense). strange

@opnsenseuser
Copy link
Copy Markdown
Member Author

prod: (opnsense theme)
grafik

development: (opnsense theme)
grafik

@opnsenseuser
Copy link
Copy Markdown
Member Author

@fichtner thx for mergin!

@marjohn56
Copy link
Copy Markdown
Member

@marjohn56 you're right.
But it's kinda weird because you've taken over the css code from opnsense theme 1: 1.
the problem should not occur with you, too

@fichtner in the production environment, the problem really only occurs in our(dark, cicada, tukan) themes. in the development environment for all themes (also opnsense). strange

perhaps it's the way the widget is pulling in the other themes.

@fichtner
Copy link
Copy Markdown
Member

I'll fix the widget. All other widgets are fine so I blame that one. ;)

@marjohn56
Copy link
Copy Markdown
Member

@opnsenseuser - As you say, Rebellion is basically Opnsense theme with colour changes, so it's a little odd. I'll wait on any changes to Rebellion until they've worked their way into the default theme.

@opnsenseuser opnsenseuser deleted the tukan/cicada-(no-expansion-delay-/-animation-/-nv.d3.css)-fixes branch September 30, 2018 07:59
fichtner pushed a commit that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants