This repository was archived by the owner on Jan 12, 2026. It is now read-only.
API Check failures should be reported#225
Merged
acunniffe merged 4 commits intoopticdev:developfrom Jun 24, 2020
Merged
Conversation
Contributor
|
API check looking great! FYI, Run is still a JSON string (see screenshot) If it's quick, would be cool to fix in this PR. If not, it can be a separate thing. I'd be willing to take it on as a learning exercise.
|
Member
Author
|
Yeah they're different pathways, I can do that next. |
added 2 commits
June 24, 2020 15:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@LouManglass found an issue where API Check was not reporting failures. It seems like an issue with how the processes are being forked. For now, it seems that removing the process.exits fix the problem, this causes 1-2 seconds of lag in some cases after the test finishes, but that's acceptable.
We should think about how we want to ensure we get analytics from other important lifecycles ie capture finished.
I also expanded the props so that a JSON string wasn't being sent into mixpanel. This should help us learn a lot more from how users call check