This repository was archived by the owner on Jan 12, 2026. It is now read-only.
added key component to response descriptions#226
Merged
acunniffe merged 2 commits intoopticdev:developfrom Jun 27, 2020
trulyronak:fix/response-description
Merged
added key component to response descriptions#226acunniffe merged 2 commits intoopticdev:developfrom trulyronak:fix/response-description
acunniffe merged 2 commits intoopticdev:developfrom
trulyronak:fix/response-description
Conversation
Contributor
|
Nice work! |
Contributor
|
Looks like you're taking a look at the other usages of the component for the same issue - awesome! |
Author
|
modified it to use a key for all things for ContentTab - i’m not 100% if this is the best key - right now I'm combining the |
Member
|
Seems like a fine place to me! nice work sir. Merging now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issue where changing response descriptions appeared to not make any changes
the issue was that react wasn't updating the components. since Response Descriptions were mapped via
ContentTabs, it needed akeycomponent in order to trigger an update when the props changedalso in this pr
different-responses.jsonto test this fixyarn.lock