Skip to content
This repository was archived by the owner on Jan 12, 2026. It is now read-only.

added key component to response descriptions#226

Merged
acunniffe merged 2 commits intoopticdev:developfrom
trulyronak:fix/response-description
Jun 27, 2020
Merged

added key component to response descriptions#226
acunniffe merged 2 commits intoopticdev:developfrom
trulyronak:fix/response-description

Conversation

@trulyronak
Copy link
Copy Markdown

Fixed issue where changing response descriptions appeared to not make any changes

the issue was that react wasn't updating the components. since Response Descriptions were mapped via ContentTabs, it needed a key component in order to trigger an update when the props changed

also in this pr

  • added different-responses.json to test this fix
  • updated yarn.lock

@devdoshi
Copy link
Copy Markdown
Contributor

Nice work!

@devdoshi
Copy link
Copy Markdown
Contributor

Looks like you're taking a look at the other usages of the component for the same issue - awesome!

@trulyronak
Copy link
Copy Markdown
Author

modified it to use a key for all things for ContentTab - i’m not 100% if this is the best key - right now I'm combining the contentTypeTab, responseStatusCode, and responseContentType to create a key for each one, but if there's a uuid field I'm missing that would be much better

@acunniffe
Copy link
Copy Markdown
Member

Seems like a fine place to me! nice work sir. Merging now

@acunniffe acunniffe merged commit 1c60f55 into opticdev:develop Jun 27, 2020
@trulyronak trulyronak added the bug Something isn't working label Jul 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants