Skip to content
This repository was archived by the owner on Jan 12, 2026. It is now read-only.

Make Diff Performance Usable #235

Merged
acunniffe merged 102 commits into from
Jul 10, 2020
Merged

Make Diff Performance Usable #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
102 commits
Select commit Hold shift + click to select a range
205735c
Progress from our work session defining the diff interface
Jun 18, 2020
b56c951
capture manager page now works off of the new interface
Jun 19, 2020
0bb2fcc
End-end with a few small issues with diff sorting
Jun 22, 2020
d6d2909
working poc
Jun 22, 2020
ac0ef9a
temp fix for reset
Jun 23, 2020
731b563
Test cases
Jun 23, 2020
fdd7db1
removing unused tests
Jun 24, 2020
0404a05
shape builder tests now rely on snapshots
Jun 24, 2020
589f85a
more snapshots for shape building.
Jun 25, 2020
97b9623
protocol for testing private sessions
Jun 25, 2020
4a57b0b
- LocalCli services should match example services
devdoshi Jun 25, 2020
87eefae
example service result should match interface
devdoshi Jun 25, 2020
7121120
constructor should receive the correct inputs
devdoshi Jun 26, 2020
1116887
clients should be able to subscribe to updates from diffs
devdoshi Jun 26, 2020
8dd2104
merge in latest
Jun 26, 2020
59ae1f8
Merge remote-tracking branch 'devdoshi/incremental-diff-interface' in…
Jun 26, 2020
a310fa5
diffs should use ignoreRequests from config
devdoshi Jun 26, 2020
c8b984b
capture context should not listen for notifications when the url is n…
devdoshi Jun 26, 2020
a9cddcd
should pool (for debug)
Jun 27, 2020
6e48072
- webpack dev server should disable compression to allow Server Sent …
devdoshi Jun 27, 2020
fe9cc5b
progress
Jun 27, 2020
8acd9cb
Merge remote-tracking branch 'devdoshi/incremental-diff-interface' in…
Jun 27, 2020
408d5c9
Class Component for Capture Store
Jun 27, 2020
2318337
Basic functionality
Jun 28, 2020
a53a4f1
Progress from our work session defining the diff interface
Jun 18, 2020
8c28692
capture manager page now works off of the new interface
Jun 19, 2020
dd5962f
End-end with a few small issues with diff sorting
Jun 22, 2020
da46f53
working poc
Jun 22, 2020
7264399
temp fix for reset
Jun 23, 2020
0fb9bb7
- LocalCli services should match example services
devdoshi Jun 25, 2020
aeda7f1
example service result should match interface
devdoshi Jun 25, 2020
7146bb8
constructor should receive the correct inputs
devdoshi Jun 26, 2020
25075ce
clients should be able to subscribe to updates from diffs
devdoshi Jun 26, 2020
3620728
diffs should use ignoreRequests from config
devdoshi Jun 26, 2020
b0caa8d
capture context should not listen for notifications when the url is n…
devdoshi Jun 26, 2020
c1acbf3
- webpack dev server should disable compression to allow Server Sent …
devdoshi Jun 27, 2020
cca1f9b
progress
Jun 27, 2020
5ea3b36
Class Component for Capture Store
Jun 27, 2020
9c7f674
Basic functionality
Jun 28, 2020
c66cdab
Tested body issues
Jun 29, 2020
95a63e3
Merge branch 'aidan-diff-incrimental' of https://github.com/opticdev/…
Jun 29, 2020
b060d55
Update DiffResultHelper.scala
acunniffe Jun 29, 2020
85a7e15
- worker should track processed and skipped interactions counts
devdoshi Jun 29, 2020
1bb665f
ux improved for diff overview page
Jun 29, 2020
615b807
Merge branch 'aidan-diff-incrimental' of https://github.com/opticdev/…
Jun 29, 2020
ec5dab8
diffs should be able to be limited to specific pathId + methods
devdoshi Jun 29, 2020
2caef5f
stats should display with progress
Jun 29, 2020
5b5b31e
Merge branch 'aidan-diff-incrimental' of https://github.com/opticdev/…
Jun 29, 2020
592cdac
incremental progress on diff page
Jun 30, 2020
c3f8322
server should retry when attempting to get exclusive access to read m…
devdoshi Jun 30, 2020
7b79222
local captures should include json bodies
devdoshi Jun 30, 2020
4ab798a
interaction iterator should indicate when it is done and handle when …
devdoshi Jun 30, 2020
debb68b
diff worker should deserialize commands
devdoshi Jun 30, 2020
4c26add
progress
Jun 30, 2020
a5a9a5d
Merge branch 'aidan-diff-incrimental' of https://github.com/opticdev/…
Jun 30, 2020
8c17da5
state should be able to be built from js/json IRfcCommand[] -> Seq[Rf…
devdoshi Jun 30, 2020
8c19117
Context fixes
Jul 1, 2020
4c9b3c1
incremental diff should be able to emit errors on diff start and duri…
devdoshi Jul 1, 2020
a31d11d
Merge branch 'aidan-diff-incrimental' of github.com:opticdev/optic in…
devdoshi Jul 1, 2020
aee8764
New Design for Diff Review Page
Jul 2, 2020
a9fcfe7
New Design for Diff Review Page
Jul 2, 2020
ea0d32c
Merge branch 'aidan-diff-incrimental' of https://github.com/opticdev/…
Jul 2, 2020
ad3a970
new UX for diff review page
Jul 3, 2020
a5bf8a5
Merge branch 'develop' into aidan-diff-incrimental
acunniffe Jul 3, 2020
25c1d40
Ignore should work from the client side
Jul 4, 2020
a2fa3d6
Merge branch 'aidan-diff-incrimental' of https://github.com/opticdev/…
Jul 4, 2020
98478c1
partial fixes to example session
Jul 4, 2020
5542cec
diffs for snapshots should not use normalized json trails
devdoshi Jul 6, 2020
5a5471f
DiffVisitorSpec should pass
devdoshi Jul 6, 2020
757e3f4
shape parameter and request parameter ids should be separate
devdoshi Jul 6, 2020
b48c549
Merge branch 'develop' into aidan-diff-incrimental
acunniffe Jul 7, 2020
c3d7feb
previews always de normalize with outer spec, not simulated spec
Jul 7, 2020
8e5ea9c
changes
Jul 7, 2020
13ae37d
backend and frontend now work with denormalized representation
Jul 8, 2020
01926d2
Merge branch 'aidan-diff-incrimental' of https://github.com/opticdev/…
Jul 8, 2020
22dd73f
ids should be guaranteed to not collide and it should be clear where …
devdoshi Jul 8, 2020
8930efb
stop traversing object keys when there is no matching shape
devdoshi Jul 8, 2020
6cdb7a8
unspecifiedshape diff interpreter should handle List<Unknown> and add…
devdoshi Jul 8, 2020
0f7a2bd
matches should handle OptionalTrail and OptionalItemTrail. Note that …
devdoshi Jul 8, 2020
5590bff
resolving a list item trail should use the item shapeId it has access to
devdoshi Jul 8, 2020
00c0ffd
array visitor already has access to potential matches. Since there co…
devdoshi Jul 8, 2020
5d186d9
Merge branch 'develop' into aidan-diff-incrimental
acunniffe Jul 9, 2020
f621b5b
Merge remote-tracking branch 'devdoshi/diff-testing' into integration…
Jul 9, 2020
62ae4d2
merged with diff bugs
Jul 9, 2020
e0ea717
added new snapshots
Jul 9, 2020
7f5ddb2
fixed duplicate random id issue
Jul 9, 2020
588987b
removed local ids
Jul 9, 2020
ef2617e
changed verbiage of commit button
Jul 9, 2020
e0d73dc
traversal should stop when there are no matches for array items
devdoshi Jul 9, 2020
d2198ab
fixed highlighting of diffs
Jul 9, 2020
f408666
commited fixes
Jul 9, 2020
cc1ced0
Merge remote-tracking branch 'devdoshi/diff-testing' into integration…
Jul 9, 2020
0ea4323
verified all snapshots from scratch
Jul 9, 2020
8e01cf2
progress and fixes
Jul 10, 2020
a536e62
Merge branch 'aidan-diff-incrimental' of https://github.com/opticdev/…
Jul 10, 2020
1745099
hidden elements on the diff page should never be '0'
Jul 10, 2020
2b91439
Merge branch 'develop' into aidan-diff-incrimental
acunniffe Jul 10, 2020
ca209b2
unimplemented interpretations should have todos
devdoshi Jul 10, 2020
a3f52f9
DiffCursor should not yield React warnings
devdoshi Jul 10, 2020
a6ea1ab
example diff service should not use normalized diffs and should have …
devdoshi Jul 10, 2020
157f1ab
updated analytics to include the current Optic version
Jul 10, 2020
2c75db2
Merge branch 'develop' into aidan-diff-incrimental
acunniffe Jul 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 0 additions & 75 deletions core/domain-snapshots/commands-to-events/example-commands.json
View file
Open in desktop

This file was deleted.

2 changes: 2 additions & 0 deletions core/domain-snapshots/commands-to-events/outputs/Case name.managed.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[
]
86 changes: 43 additions & 43 deletions ...s/events-interactions-diff-interpretation-ui-render/a known field is missing.managed.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"events" : [
{
"PathComponentAdded" : {
"pathId" : "path_1",
"pathId" : "baseline-path_1",
"parentPathId" : "root",
"name" : "users",
"eventContext" : {
Expand All @@ -15,15 +15,15 @@
},
{
"PathParameterAdded" : {
"pathId" : "path_2",
"parentPathId" : "path_1",
"pathId" : "baseline-path_2",
"parentPathId" : "baseline-path_1",
"name" : ":userId",
"eventContext" : null
}
},
{
"ShapeAdded" : {
"shapeId" : "shape_9",
"shapeId" : "baseline-shape_9",
"baseShapeId" : "$string",
"parameters" : {
"DynamicParameterList" : {
Expand All @@ -37,18 +37,18 @@
},
{
"PathParameterShapeSet" : {
"pathId" : "path_2",
"pathId" : "baseline-path_2",
"shapeDescriptor" : {
"shapeId" : "shape_9",
"shapeId" : "baseline-shape_9",
"isRemoved" : false
},
"eventContext" : null
}
},
{
"PathComponentAdded" : {
"pathId" : "path_3",
"parentPathId" : "path_2",
"pathId" : "baseline-path_3",
"parentPathId" : "baseline-path_2",
"name" : "profile",
"eventContext" : {
"clientId" : "ccc",
Expand All @@ -60,8 +60,8 @@
},
{
"RequestParameterAddedByPathAndMethod" : {
"parameterId" : "parameter_5",
"pathId" : "path_3",
"parameterId" : "baseline-request-parameter_1",
"pathId" : "baseline-path_3",
"httpMethod" : "GET",
"parameterLocation" : "query",
"name" : "queryString",
Expand All @@ -75,7 +75,7 @@
},
{
"ShapeAdded" : {
"shapeId" : "shape_10",
"shapeId" : "baseline-shape_10",
"baseShapeId" : "$object",
"parameters" : {
"DynamicParameterList" : {
Expand All @@ -94,9 +94,9 @@
},
{
"RequestParameterShapeSet" : {
"parameterId" : "parameter_5",
"parameterId" : "baseline-request-parameter_1",
"parameterDescriptor" : {
"shapeId" : "shape_10",
"shapeId" : "baseline-shape_10",
"isRemoved" : false
},
"eventContext" : {
Expand All @@ -109,8 +109,8 @@
},
{
"RequestAdded" : {
"requestId" : "request_1",
"pathId" : "path_3",
"requestId" : "baseline-request_1",
"pathId" : "baseline-path_3",
"httpMethod" : "GET",
"eventContext" : {
"clientId" : "ccc",
Expand All @@ -122,8 +122,8 @@
},
{
"ResponseAddedByPathAndMethod" : {
"responseId" : "response_1",
"pathId" : "path_3",
"responseId" : "baseline-response_1",
"pathId" : "baseline-path_3",
"httpMethod" : "GET",
"httpStatusCode" : 200,
"eventContext" : {
Expand All @@ -136,7 +136,7 @@
},
{
"ShapeAdded" : {
"shapeId" : "shape_8",
"shapeId" : "baseline-shape_8",
"baseShapeId" : "$object",
"parameters" : {
"DynamicParameterList" : {
Expand All @@ -155,7 +155,7 @@
},
{
"ShapeAdded" : {
"shapeId" : "shape_2",
"shapeId" : "baseline-shape_2",
"baseShapeId" : "$number",
"parameters" : {
"DynamicParameterList" : {
Expand All @@ -174,13 +174,13 @@
},
{
"FieldAdded" : {
"fieldId" : "parameter_1",
"shapeId" : "shape_8",
"fieldId" : "baseline-field_1",
"shapeId" : "baseline-shape_8",
"name" : "age",
"shapeDescriptor" : {
"FieldShapeFromShape" : {
"fieldId" : "parameter_1",
"shapeId" : "shape_2"
"fieldId" : "baseline-field_1",
"shapeId" : "baseline-shape_2"
}
},
"eventContext" : {
Expand All @@ -193,7 +193,7 @@
},
{
"ShapeAdded" : {
"shapeId" : "shape_4",
"shapeId" : "baseline-shape_4",
"baseShapeId" : "$string",
"parameters" : {
"DynamicParameterList" : {
Expand All @@ -212,7 +212,7 @@
},
{
"ShapeAdded" : {
"shapeId" : "shape_5",
"shapeId" : "baseline-shape_5",
"baseShapeId" : "$list",
"parameters" : {
"DynamicParameterList" : {
Expand All @@ -231,13 +231,13 @@
},
{
"FieldAdded" : {
"fieldId" : "parameter_2",
"shapeId" : "shape_8",
"fieldId" : "baseline-field_2",
"shapeId" : "baseline-shape_8",
"name" : "cities",
"shapeDescriptor" : {
"FieldShapeFromShape" : {
"fieldId" : "parameter_2",
"shapeId" : "shape_5"
"fieldId" : "baseline-field_2",
"shapeId" : "baseline-shape_5"
}
},
"eventContext" : {
Expand All @@ -250,7 +250,7 @@
},
{
"ShapeAdded" : {
"shapeId" : "shape_6",
"shapeId" : "baseline-shape_6",
"baseShapeId" : "$string",
"parameters" : {
"DynamicParameterList" : {
Expand All @@ -269,13 +269,13 @@
},
{
"FieldAdded" : {
"fieldId" : "parameter_3",
"shapeId" : "shape_8",
"fieldId" : "baseline-field_3",
"shapeId" : "baseline-shape_8",
"name" : "firstName",
"shapeDescriptor" : {
"FieldShapeFromShape" : {
"fieldId" : "parameter_3",
"shapeId" : "shape_6"
"fieldId" : "baseline-field_3",
"shapeId" : "baseline-shape_6"
}
},
"eventContext" : {
Expand All @@ -288,7 +288,7 @@
},
{
"ShapeAdded" : {
"shapeId" : "shape_7",
"shapeId" : "baseline-shape_7",
"baseShapeId" : "$string",
"parameters" : {
"DynamicParameterList" : {
Expand All @@ -307,13 +307,13 @@
},
{
"FieldAdded" : {
"fieldId" : "parameter_4",
"shapeId" : "shape_8",
"fieldId" : "baseline-field_4",
"shapeId" : "baseline-shape_8",
"name" : "lastName",
"shapeDescriptor" : {
"FieldShapeFromShape" : {
"fieldId" : "parameter_4",
"shapeId" : "shape_7"
"fieldId" : "baseline-field_4",
"shapeId" : "baseline-shape_7"
}
},
"eventContext" : {
Expand All @@ -328,10 +328,10 @@
"ShapeParameterShapeSet" : {
"shapeDescriptor" : {
"ProviderInShape" : {
"shapeId" : "shape_5",
"shapeId" : "baseline-shape_5",
"providerDescriptor" : {
"ShapeProvider" : {
"shapeId" : "shape_4"
"shapeId" : "baseline-shape_4"
}
},
"consumingParameterId" : "$listItem"
Expand All @@ -347,10 +347,10 @@
},
{
"ResponseBodySet" : {
"responseId" : "response_1",
"responseId" : "baseline-response_1",
"bodyDescriptor" : {
"httpContentType" : "application/json",
"shapeId" : "shape_8",
"shapeId" : "baseline-shape_8",
"isRemoved" : false
},
"eventContext" : {
Expand Down
Loading