This repository was archived by the owner on Jan 12, 2026. It is now read-only.
Conversation
protocol for debugging a user session added.
- diffs should use pointers to interactions - interactions should be loadable by capture - work to be done: ignoreRequests, undocumented urls, misc ui discrepancies
…to incremental-diff-interface
…Events to pass unmangled - diff worker should build stats and undocumented-urls
…to incremental-diff-interface
- diffs should use pointers to interactions - interactions should be loadable by capture - work to be done: ignoreRequests, undocumented urls, misc ui discrepancies
…ing keys to objects
…we will probably need to add some ids to those trail case classes to implement the remaining functionality
…uld be multiple matches (e.g. a List<OneOf<string, number>>) this code probably does not handle all cases
…optic into aidan-diff-incrimental
devdoshi
reviewed
Jul 10, 2020
| @@ -10,7 +10,7 @@ class JvmStableHashableSpec extends FunSpec { | |||
| InteractionTrail(Seq(Url(), Method("GET"))), | |||
| SpecPath("path_wYt9lgNJVf") | |||
| ) | |||
| assert(diff.toHash()(JvmStableHashable.hash) == "03bbd8f6b62f7fa0661fa2040dbacc1a914a2970") | |||
| assert(diff.toHash()(JvmStableHashable.hash) == "756c80f2212b17c3da0c4a24079469644c9dac62") | |||
Contributor
There was a problem hiding this comment.
Interesting that this changed, I guess the file changed without this test being run
…access to the ui's latest events
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey guys! Some big improvements to both performance and the user experience of the diff mode are ready to merge. The entire flow has been reworked based on learnings from the last few months.
regressions:
rough edges:
also of note:
We also have to talk about the DiffManager, which is now deprecated, it's being used on the Testing Dashboard and should have equivalent functionality available too it in the new DiffResultHelper