This repository was archived by the owner on Jan 12, 2026. It is now read-only.
Implement flattened-rows rendering ShapeViewer behind feature flag#299
Merged
JaapRood merged 9 commits intoopticdev:developfrom Aug 6, 2020
Merged
Conversation
…d a feature flag that's disabled by default
…ute when feature flag is enabled
Contributor
Author
|
@acunniffe I would have just merged this, if it wasn't for the failing checks. To me those failures seem totally unrelated to the changes I've made, but it would be good to get your confirmation on that as well. |
Member
|
Not seeing anything would ‘fail’ this. Rerunning, and will checkout if it still failed. |
Contributor
Author
|
@acunniffe it builds, but end-to-end tests job fails, not able to check them out. The way that works seems to have been last changed recently through #297. |
Contributor
Author
|
Double checked everything and was confident this wouldn't break anything. @acunniffe still keen on a retrospective review, just to make sure I've siloed it off behind a feature flag properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new approach to implementing the
DiffViewer, using a "view model" approach to control what's rendered. For now, it's hidden behind a feature flag and rendered by adding the/flattenedsuffix to a diff review URL.So far, we're only exploring how the component itself should work and whether it will give the amount of control and expressiveness to better control the responsiveness of the UI. Eventually, for this to bear fruit, the view model should be generated in a more direct way from the domain, without performing the entire diff render all at once. That is outside the scope of this PR: proving this kind of view model can power this type of UI in the first place. We shouldn't also care too much about this the debug route is wired up: a lot of that maze of react components might not even make it to the version that hits production, so caring about the ergonomics of that now is quite likely wasted time.