Skip to content
This repository was archived by the owner on Jan 12, 2026. It is now read-only.

Implement flattened-rows rendering ShapeViewer behind feature flag#299

Merged
JaapRood merged 9 commits intoopticdev:developfrom
JaapRood:feature/flattened-row-shape-viewer
Aug 6, 2020
Merged

Implement flattened-rows rendering ShapeViewer behind feature flag#299
JaapRood merged 9 commits intoopticdev:developfrom
JaapRood:feature/flattened-row-shape-viewer

Conversation

@JaapRood
Copy link
Copy Markdown
Contributor

@JaapRood JaapRood commented Aug 4, 2020

This pull request adds a new approach to implementing the DiffViewer, using a "view model" approach to control what's rendered. For now, it's hidden behind a feature flag and rendered by adding the /flattened suffix to a diff review URL.

So far, we're only exploring how the component itself should work and whether it will give the amount of control and expressiveness to better control the responsiveness of the UI. Eventually, for this to bear fruit, the view model should be generated in a more direct way from the domain, without performing the entire diff render all at once. That is outside the scope of this PR: proving this kind of view model can power this type of UI in the first place. We shouldn't also care too much about this the debug route is wired up: a lot of that maze of react components might not even make it to the version that hits production, so caring about the ergonomics of that now is quite likely wasted time.

@JaapRood JaapRood marked this pull request as ready for review August 6, 2020 10:56
@JaapRood JaapRood requested a review from acunniffe August 6, 2020 10:57
@JaapRood
Copy link
Copy Markdown
Contributor Author

JaapRood commented Aug 6, 2020

@acunniffe I would have just merged this, if it wasn't for the failing checks. To me those failures seem totally unrelated to the changes I've made, but it would be good to get your confirmation on that as well.

@acunniffe
Copy link
Copy Markdown
Member

Not seeing anything would ‘fail’ this. Rerunning, and will checkout if it still failed.

@JaapRood
Copy link
Copy Markdown
Contributor Author

JaapRood commented Aug 6, 2020

@acunniffe it builds, but end-to-end tests job fails, not able to check them out. The way that works seems to have been last changed recently through #297.

@JaapRood
Copy link
Copy Markdown
Contributor Author

JaapRood commented Aug 6, 2020

Double checked everything and was confident this wouldn't break anything. @acunniffe still keen on a retrospective review, just to make sure I've siloed it off behind a feature flag properly.

@JaapRood JaapRood deleted the feature/flattened-row-shape-viewer branch August 6, 2020 14:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants