This repository was archived by the owner on Jan 12, 2026. It is now read-only.
Render new ShapeViewer by directly traversing HttpInteraction#300
Merged
JaapRood merged 2 commits intoopticdev:developfrom Aug 6, 2020
Merged
Conversation
JaapRood
force-pushed
the
feature/shape-viewer-interaction-traverser
branch
from
45aa6c1 to
a5a4dcf
Compare
Contributor
Author
|
@acunniffe a sanity check in traversals could never hurt, but feel free to ignore as it's one of those things of it either working, or not. |
Member
|
@JaapRood this looks right to me. Definitely nice to see some of those domain logic moving out. You made quick work of this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Side-stepping a whole bunch of the domain, any browser is perfectly capable of traversing a JSON structure itself. In our case, traversing the
bodyof either theRequestorResponseof anHttpInteractionto render the basic shape of the shape viewer, powering the row-level view model.This depends on #299 to get merged, first. Through that, this all happens behind a feature flag, so not much to review. All missing functionality
RenderShapeprovided, like marking missing fields and folding of collections, will be reimplemented incrementally and is beyond the scope of this PR.