Raju/config refactor#1163
Closed
raju-opti wants to merge 1 commit into
Closed
Conversation
raju-opti
force-pushed
the
raju/config-refactor
branch
from
be4c02b to
f5de932
Compare
|
coverage: 77.732% (+0.03%) from 77.701% — raju/config-refactor into master |
- Simplify createProjectConfig to accept a datafile string directly instead of string | object, inlining datafile validation - Remove the separate config_validator module and its tests - Break monolithic config builder into focused parse functions: parseAudienceConfig, parseAttributeConfig, parseGroupConfig, parseRolloutConfig, parseIntegrationConfig, parseExperimentConfig, parseFeatureFlagConfig - Eliminate mutation-safe datafile copy in favor of direct construction - Refactor redundant iterations over experiments and feature flags - Remove lodash dev dependency Benchmarks show ~10% faster config parsing for 3-4 MB datafiles. Removing createMutationSafeDatafileCopy also fixes a memory issue where it allocated ~4x the datafile size in shallow copies per call, causing OOM under repeated parsing of large datafiles. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
raju-opti
force-pushed
the
raju/config-refactor
branch
from
f5de932 to
e8468c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "why", or other context.
Test plan
Issues